Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1646573002: WebViewProxy now propagates first responder status to the webview. (Closed)

Created:
4 years, 10 months ago by lpromero
Modified:
4 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WebViewProxy now propagates first responder status to the webview. With this CL, calling becomeFirstResponder on a web view proxy makes the potential web view first responder. BUG=556455 R=eugenebut@chromium.org Committed: https://crrev.com/8d9b0469d80381defa8b15dd48853c456703f458 Cr-Commit-Position: refs/heads/master@{#371820}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M ios/web/public/web_state/crw_web_view_proxy.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ios/web/web_state/crw_web_view_proxy_impl.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/web_state/ui/crw_web_view_content_view.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
lpromero
4 years, 10 months ago (2016-01-27 17:35:49 UTC) #1
Eugene But (OOO till 7-30)
lgtm
4 years, 10 months ago (2016-01-27 17:43:07 UTC) #4
lpromero
4 years, 10 months ago (2016-01-27 17:43:13 UTC) #5
lpromero
On 2016/01/27 17:43:13, lpromero wrote: Thanks for the review!
4 years, 10 months ago (2016-01-27 17:43:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1646573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1646573002/1
4 years, 10 months ago (2016-01-27 17:43:54 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-27 17:57:23 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-01-27 17:58:32 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8d9b0469d80381defa8b15dd48853c456703f458
Cr-Commit-Position: refs/heads/master@{#371820}

Powered by Google App Engine
This is Rietveld 408576698