Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1646543006: Move static before type. (Closed)

Created:
4 years, 10 months ago by floitsch
Modified:
4 years, 10 months ago
Reviewers:
Cutch, srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M runtime/vm/object.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
floitsch
4 years, 10 months ago (2016-01-28 17:15:04 UTC) #2
Cutch
lgtm
4 years, 10 months ago (2016-01-28 17:15:53 UTC) #4
Cutch
On 2016/01/28 17:15:53, Cutch wrote: > lgtm *ping*
4 years, 10 months ago (2016-02-04 22:16:39 UTC) #5
floitsch
Committed patchset #1 (id:1) manually as 8811cba569e5c9f6b32affd0d195ac676b14b2dc (presubmit successful).
4 years, 10 months ago (2016-02-04 23:12:52 UTC) #7
floitsch
4 years, 10 months ago (2016-02-04 23:13:51 UTC) #8
Message was sent while issue was closed. 
On 2016/02/04 22:16:39, Cutch wrote:
> On 2016/01/28 17:15:53, Cutch wrote:
> > lgtm
> 
> *ping*

Thanks.
Apparently I tried to git cl land, it didn't work (not up to date), but I still
deleted the branch...

Had to recreate the branch...

Powered by Google App Engine
This is Rietveld 408576698