Refactor away SVGPathSource

Refactor away SVGPathSource

This CL moves the SVGPathParser::initialCommandIsMoveTo functionality into
the path data sources that needs this check - eliminating the need for the
SVGPathSource method peekSegmentType.
This leaves SVGPathParser::parsePath as a fairly trivial loop doing
parseSegment + emitSegment. Converting this function to a templated one,
The remaining two methods of the SVGPathSource interface no longer need to
be (called) virtual(ly) - allowing us too remove the interface entirely,
and simplify and inline code (hasMoreData) accordingly.
The net effect on (binary) code size is a roughtly 1.5k reduction.
Also rename and refactor some of the helpers in SVGPathStringSource.cpp
to try to better illustrate what they are used for.

BUG=467592
Committed: https://crrev.com/848766c79ce487bc33acea38eb7c6b0cc821e6a7
Cr-Commit-Position: refs/heads/master@{#372329}

[fs, 2016-01-28 15:17:06]

fs@opera.com changed reviewers:
+ fmalita@chromium.org, pdr@chromium.org

[f(malita), 2016-01-28 16:34:06]

Nice, LGTM!

https://codereview.chromium.org/1646543004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/svg/SVGPathParser.h (right):

https://codereview.chromium.org/1646543004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/svg/SVGPathParser.h:35: class CORE_EXPORT
SVGPathParser {
Nit: class -> namespace?

[fs, 2016-01-28 19:09:37]

https://codereview.chromium.org/1646543004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/svg/SVGPathParser.h (right):

https://codereview.chromium.org/1646543004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/svg/SVGPathParser.h:35: class CORE_EXPORT
SVGPathParser {
On 2016/01/28 at 16:34:06, f(malita) wrote:
> Nit: class -> namespace?

Sure, unless pdr minds.

[pdr., 2016-01-28 19:49:51]

LGTM

On 2016/01/28 at 19:09:37, fs wrote:
>
https://codereview.chromium.org/1646543004/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/svg/SVGPathParser.h (right):
> 
>
https://codereview.chromium.org/1646543004/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/svg/SVGPathParser.h:35: class CORE_EXPORT
SVGPathParser {
> On 2016/01/28 at 16:34:06, f(malita) wrote:
> > Nit: class -> namespace?
> 
> Sure, unless pdr minds.

I don't mind either way.

[fs, 2016-01-29 11:22:58]

The CQ bit was checked by fs@opera.com

[fs, 2016-01-29 11:22:58]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org,
fmalita@chromium.org
Link to the patchset: https://codereview.chromium.org/1646543004/#ps20001
(title: "Use namespace")

[commit-bot: I haz the power, 2016-01-29 11:23:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1646543004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1646543004/20001

[commit-bot: I haz the power, 2016-01-29 11:28:27]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-29 11:29:34]

Description was changed from

==========
Refactor away SVGPathSource

This CL moves the SVGPathParser::initialCommandIsMoveTo functionality into
the path data sources that needs this check - eliminating the need for the
SVGPathSource method peekSegmentType.
This leaves SVGPathParser::parsePath as a fairly trivial loop doing
parseSegment + emitSegment. Converting this function to a templated one,
The remaining two methods of the SVGPathSource interface no longer need to
be (called) virtual(ly) - allowing us too remove the interface entirely,
and simplify and inline code (hasMoreData) accordingly.
The net effect on (binary) code size is a roughtly 1.5k reduction.
Also rename and refactor some of the helpers in SVGPathStringSource.cpp
to try to better illustrate what they are used for.

BUG=467592
==========

to

==========
Refactor away SVGPathSource

This CL moves the SVGPathParser::initialCommandIsMoveTo functionality into
the path data sources that needs this check - eliminating the need for the
SVGPathSource method peekSegmentType.
This leaves SVGPathParser::parsePath as a fairly trivial loop doing
parseSegment + emitSegment. Converting this function to a templated one,
The remaining two methods of the SVGPathSource interface no longer need to
be (called) virtual(ly) - allowing us too remove the interface entirely,
and simplify and inline code (hasMoreData) accordingly.
The net effect on (binary) code size is a roughtly 1.5k reduction.
Also rename and refactor some of the helpers in SVGPathStringSource.cpp
to try to better illustrate what they are used for.

BUG=467592

Committed: https://crrev.com/848766c79ce487bc33acea38eb7c6b0cc821e6a7
Cr-Commit-Position: refs/heads/master@{#372329}
==========

[commit-bot: I haz the power, 2016-01-29 11:29:35]

Patchset 2 (id:??) landed as
https://crrev.com/848766c79ce487bc33acea38eb7c6b0cc821e6a7
Cr-Commit-Position: refs/heads/master@{#372329}