Create the drag image at target scale factor when possible.

Create the drag image at target scale factor when possible.

BUG=581753
TEST=manual

Committed: https://crrev.com/3eed101e954b794f7ec08fad9a8e68bc8ba94be3
Cr-Commit-Position: refs/heads/master@{#371973}

[oshima, 2016-01-27 18:04:44]

Description was changed from

==========
Use native pixels in drag

BUG=
==========

to

==========
Create the drag image at target scale fact when possible.

BUG=581753
TEST=manual
==========

[oshima, 2016-01-27 18:04:44]

oshima@chromium.org changed reviewers:
+ dcheng@chromium.org

[oshima, 2016-01-27 18:49:41]

Patchset #4 (id:60001) has been deleted

[oshima, 2016-01-27 18:49:45]

Patchset #3 (id:40001) has been deleted

[oshima, 2016-01-27 18:58:59]

Patchset #1 (id:1) has been deleted

[oshima, 2016-01-27 18:59:04]

Patchset #1 (id:20001) has been deleted

[oshima, 2016-01-27 19:01:02]

Description was changed from

==========
Create the drag image at target scale fact when possible.

BUG=581753
TEST=manual
==========

to

==========
Create the drag image at target scale factor when possible.

BUG=581753
TEST=manual
==========

[oshima, 2016-01-27 19:01:09]

https://codereview.chromium.org/1646543002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/page/DragController.cpp (right):

https://codereview.chromium.org/1646543002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/page/DragController.cpp:896:
imageSizeInPixels.scale(src->host()->deviceScaleFactor());
This is same as what LocalFrame is doing here:

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

[oshima, 2016-01-27 19:01:09]

https://codereview.chromium.org/1646543002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/page/DragController.cpp (right):

https://codereview.chromium.org/1646543002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/page/DragController.cpp:896:
imageSizeInPixels.scale(src->host()->deviceScaleFactor());
This is same as what LocalFrame is doing here:

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

[dcheng, 2016-01-27 19:05:24]

Any chance we can write a test? There's a DRT method to dump the drag image if
that helps:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

[oshima, 2016-01-27 19:08:56]

On 2016/01/27 19:05:24, dcheng wrote:
> Any chance we can write a test? There's a DRT method to dump the drag image if
> that helps:
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

Will do. anything else you want me to change/address?

[dcheng, 2016-01-27 19:14:32]

The rest seems reasonable (I assume we'll be able to clean it up once both
patches have landed?)

[oshima, 2016-01-27 19:22:40]

On 2016/01/27 19:14:32, dcheng wrote:
> The rest seems reasonable (I assume we'll be able to clean it up once both
> patches have landed?)

What clean up are you referring to? If you're talking about
"host()->deviceScaleFactor()",
we still need this for old (existing) path, as you can see that LocalFrame.cpp
does the same,
until all platforms migrate to the new scaling scheme.

It'll be either 52 or 53, depending on how quickly we can migrate Mac and
Android. (Win and Linux are planned on 51)

[oshima, 2016-01-27 19:43:57]

I added new test. PTAL

I included the expected image as a reference. It's using 2x image and not blurry
as you can see.

TestExpectation already have [NeedsManualRebaseline] for this directory (it's
pending due to crbug.com/577300).

[oshima, 2016-01-27 19:44:51]

https://codereview.chromium.org/1646543002/diff/100001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/fast/hidpi/static/drag-image.html (right):

https://codereview.chromium.org/1646543002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/fast/hidpi/static/drag-image.html:5: height:
50px;
I'm using skewed size (original image is square) to make sure it's properly
scaled at the target scale.

[dcheng, 2016-01-27 22:41:34]

lgtm, hopefully we can get this migrated over sooner rather than later. thanks!

[oshima, 2016-01-28 01:20:45]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2016-01-28 01:22:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1646543002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1646543002/100001

[commit-bot: I haz the power, 2016-01-28 02:52:16]

Description was changed from

==========
Create the drag image at target scale factor when possible.

BUG=581753
TEST=manual
==========

to

==========
Create the drag image at target scale factor when possible.

BUG=581753
TEST=manual
==========

[commit-bot: I haz the power, 2016-01-28 02:52:17]

Committed patchset #2 (id:100001)

[commit-bot: I haz the power, 2016-01-28 02:53:19]

Description was changed from

==========
Create the drag image at target scale factor when possible.

BUG=581753
TEST=manual
==========

to

==========
Create the drag image at target scale factor when possible.

BUG=581753
TEST=manual

Committed: https://crrev.com/3eed101e954b794f7ec08fad9a8e68bc8ba94be3
Cr-Commit-Position: refs/heads/master@{#371973}
==========

[commit-bot: I haz the power, 2016-01-28 02:53:20]

Patchset 2 (id:??) landed as
https://crrev.com/3eed101e954b794f7ec08fad9a8e68bc8ba94be3
Cr-Commit-Position: refs/heads/master@{#371973}