Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 16465007: clean up test importer to use webkit_finder and update tests (Closed)

Created:
7 years, 6 months ago by Dirk Pranke
Modified:
7 years, 5 months ago
Reviewers:
eseidel, ojan
CC:
blink-reviews, eae+blinkwatch, rhauck, jochen (gone - plz use gerrit)
Visibility:
Public.

Description

clean up test importer to use webkit_finder and update tests The old tests were using source_dir and repo_dir incorrectly and were using a real filesystem. This patch fixes that and cleans up the importer code to use webkit_finder while we're at it. R=ojan@chromium.org, eseidel@chromium.org BUG=247454 Change commited as r152037.

Patch Set 1 #

Patch Set 2 : re-upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -22 lines) Patch
M Tools/Scripts/webkitpy/w3c/test_importer.py View 2 chunks +4 lines, -5 lines 0 comments Download
M Tools/Scripts/webkitpy/w3c/test_importer_unittest.py View 2 chunks +16 lines, -17 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Dirk Pranke
7 years, 6 months ago (2013-06-07 00:21:05 UTC) #1
eseidel
lgtm This is kinda awesome. I suspect we should use WebKitFinder in many more places. ...
7 years, 6 months ago (2013-06-07 00:22:46 UTC) #2
Dirk Pranke
7 years, 6 months ago (2013-06-07 00:24:53 UTC) #3
On 2013/06/07 00:22:46, eseidel wrote:
> lgtm
> 
> This is kinda awesome.
> 
> I suspect we should use WebKitFinder in many more places. :)
> 
> I assume webkitfinder already exists and you didn't forget to git add the
file?

Yes, though I had forgotten it existed when I wrote this the first time :).

Powered by Google App Engine
This is Rietveld 408576698