Issue 16465007: clean up test importer to use webkit_finder and update tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16465007: clean up test importer to use webkit_finder and update tests (Closed)

Created:
7 years, 6 months ago by Dirk Pranke

Modified:
7 years, 6 months ago

Reviewers:
eseidel, ojan

CC:
blink-reviews, eae+blinkwatch, rhauck, jochen (gone - plz use gerrit)

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

clean up test importer to use webkit_finder and update tests The old tests were using source_dir and repo_dir incorrectly and were using a real filesystem. This patch fixes that and cleans up the importer code to use webkit_finder while we're at it. R=ojan@chromium.org, eseidel@chromium.org BUG=247454 Change commited as r152037.

Patch Set 1 #

Patch Set 2 : re-upload #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -22 lines)			Patch
	M	Tools/Scripts/webkitpy/w3c/test_importer.py	View		2 chunks	+4 lines, -5 lines	0 comments	Download
	M	Tools/Scripts/webkitpy/w3c/test_importer_unittest.py	View		2 chunks	+16 lines, -17 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

eseidel

lgtm This is kinda awesome. I suspect we should use WebKitFinder in many more places. ...

7 years, 6 months ago (2013-06-07 00:22:46 UTC) #2

Dirk Pranke

7 years, 6 months ago (2013-06-07 00:24:53 UTC) #3

On 2013/06/07 00:22:46, eseidel wrote:
> lgtm
> 
> This is kinda awesome.
> 
> I suspect we should use WebKitFinder in many more places. :)
> 
> I assume webkitfinder already exists and you didn't forget to git add the
file?

Yes, though I had forgotten it existed when I wrote this the first time :).

Expand Messages | Collapse Messages