Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 1646493004: Show message when "Request app banner" on DevTools is clicked but not enabled. (Closed)

Created:
4 years, 10 months ago by horo
Modified:
4 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Show message when "Request app banner" on DevTools is clicked but not enabled. Currently "Add To Shelf" feature is not enabled by default on Desktop. So we should show an debug message. BUG=540491 Committed: https://crrev.com/0ff5dcbf300b911203f4119a08a8275c2e68ed4b Cr-Commit-Position: refs/heads/master@{#372320}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/ui/browser.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
horo
dfalcantara@ Could you please review this?
4 years, 10 months ago (2016-01-28 03:11:03 UTC) #3
gone
This might be better for dominickn@; he did the desktop implementation.
4 years, 10 months ago (2016-01-28 18:16:16 UTC) #4
gone
+dom
4 years, 10 months ago (2016-01-28 18:16:32 UTC) #6
dominickn
lgtm
4 years, 10 months ago (2016-01-28 22:08:43 UTC) #7
dominickn
FYI: app banners are enabled by default on ChromeOS, but are disabled by default on ...
4 years, 10 months ago (2016-01-28 22:09:18 UTC) #8
horo
Thank you.
4 years, 10 months ago (2016-01-28 23:41:07 UTC) #9
horo
jochen@ Could you please review?
4 years, 10 months ago (2016-01-28 23:41:33 UTC) #11
jochen (gone - plz use gerrit)
lgtm
4 years, 10 months ago (2016-01-29 09:19:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1646493004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1646493004/1
4 years, 10 months ago (2016-01-29 09:33:18 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-29 10:15:18 UTC) #16
commit-bot: I haz the power
4 years, 10 months ago (2016-01-29 10:16:25 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0ff5dcbf300b911203f4119a08a8275c2e68ed4b
Cr-Commit-Position: refs/heads/master@{#372320}

Powered by Google App Engine
This is Rietveld 408576698