Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1646483002: Fix //chrome/app/test_support dependency on //chrome/browser/policy:path_parser (Closed)

Created:
4 years, 11 months ago by Tomasz Moniuszko
Modified:
4 years, 11 months ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix //chrome/app/test_support dependency on //chrome/browser/policy:path_parser BUG= Committed: https://crrev.com/e5f573049cfc96b29515fc04cbbcaca10ec08f0a Cr-Commit-Position: refs/heads/master@{#371790}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/app/BUILD.gn View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Tomasz Moniuszko
4 years, 11 months ago (2016-01-27 14:27:58 UTC) #2
grt (UTC plus 2)
lgtm
4 years, 11 months ago (2016-01-27 14:31:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1646483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1646483002/1
4 years, 11 months ago (2016-01-27 14:47:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 15:20:38 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 15:21:41 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e5f573049cfc96b29515fc04cbbcaca10ec08f0a
Cr-Commit-Position: refs/heads/master@{#371790}

Powered by Google App Engine
This is Rietveld 408576698