Make SkPixelXorXfermode's opColor be SkPMColor

Make SkPixelXorXfermode's opColor be SkPMColor

Xoring an SkColor with 2 SkPMColors creates rendering inconsistencies on Macs and some Android devices in 8888.

AFAICT Android doesn't compensate for this so we may be changing SkPixelXorXfermode's behavior on Android.

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1646453003

Committed: https://skia.googlesource.com/skia/+/98124ef2f991678ff3ed6d2cbf416a12679a2e15

[robertphillips, 2016-01-27 15:13:37]

Description was changed from

==========
Make SkPixelXorXfermode's opColor be SkPMColor
==========

to

==========
Make SkPixelXorXfermode's opColor be SkPMColor
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-01-27 15:26:45]

Description was changed from

==========
Make SkPixelXorXfermode's opColor be SkPMColor
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Make SkPixelXorXfermode's opColor be SkPMColor

Xoring an SkColor with 2 SkPMColors creates rendering inconsistencies on Macs
and some Android devices in 8888.

AFAICT Android doesn't compensate for this so we may be changing
SkPixelXorXfermode's behavior on Android.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-01-27 15:26:45]

robertphillips@google.com changed reviewers:
+ djsollen@google.com, reed@google.com

[reed1, 2016-01-28 05:14:03]

I hate this mode. Its dumb. Let's remove it from android.

lgtm

[robertphillips, 2016-01-28 13:34:49]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-28 13:34:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1646453003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1646453003/20001

[commit-bot: I haz the power, 2016-01-28 13:35:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-28 13:35:48]

Dry run: Try jobs failed on following builders:
  Build-Mac10.9-Clang-Arm7-Debug-iOS-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac10.9-Clang-...)
  skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[robertphillips, 2016-01-28 13:42:01]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-28 13:42:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1646453003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1646453003/40001

[commit-bot: I haz the power, 2016-01-28 13:55:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-28 13:55:56]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-01-28 14:40:28]

The CQ bit was checked by robertphillips@google.com

[robertphillips, 2016-01-28 14:40:28]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1646453003/#ps40001
(title: "update to ToT")

[commit-bot: I haz the power, 2016-01-28 14:40:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1646453003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1646453003/40001

[commit-bot: I haz the power, 2016-01-28 14:41:13]

Description was changed from

==========
Make SkPixelXorXfermode's opColor be SkPMColor

Xoring an SkColor with 2 SkPMColors creates rendering inconsistencies on Macs
and some Android devices in 8888.

AFAICT Android doesn't compensate for this so we may be changing
SkPixelXorXfermode's behavior on Android.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Make SkPixelXorXfermode's opColor be SkPMColor

Xoring an SkColor with 2 SkPMColors creates rendering inconsistencies on Macs
and some Android devices in 8888.

AFAICT Android doesn't compensate for this so we may be changing
SkPixelXorXfermode's behavior on Android.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/98124ef2f991678ff3ed6d2cbf416a12679a2e15
==========

[commit-bot: I haz the power, 2016-01-28 14:41:13]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/98124ef2f991678ff3ed6d2cbf416a12679a2e15