Issue 164643002: [Android] Eliminate JNI hop for critical path gestures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164643002: [Android] Eliminate JNI hop for critical path gestures (Closed)

Created:
6 years, 10 months ago by jdduke (slow)

Modified:
6 years, 10 months ago

Reviewers:
Xianzhu

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

[Android] Eliminate JNI hop for critical path gestures Previously, all gestures would pass through Java as they were filtered prior to being forwarded to the renderer. However, only a small subset of gestures really need to be seen during this filtering phase. The rest can be accommodated simply by inspecting the corresponding gesture ack. This saves ~20us per GestureScrollUpdate and GesturePinchUpdate. BUG=341613 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251181

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -38 lines)			Patch
	M	content/browser/android/content_view_core_impl.cc	View		2 chunks	+12 lines, -6 lines	0 comments	Download
	M	content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java	View		6 chunks	+19 lines, -32 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jdduke (slow)

wangxianzhu@: PTAL. This should have no meaningful change on behavior, but saves us some time ...

6 years, 10 months ago (2014-02-13 20:37:09 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/164643002/1

6 years, 10 months ago (2014-02-13 21:07:32 UTC) #4

Message was sent while issue was closed.

Change committed as 251181

Expand Messages | Collapse Messages