Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1646413002: [css-flexbox] Add a missing needsLayout() check (Closed)

Created:
4 years, 10 months ago by cbiesinger
Modified:
4 years, 10 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, cbiesinger, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a missing needsLayout() check Without this, we will sometimes update our cache without having forced a new layout, which means it will contain a length that still has the override size applied, which is bad. BUG=582212, 576859, 582151 R=leviw@chromium.org Committed: https://crrev.com/8b1f305aa32f871dd7dbda0da422adc63598ca3b Cr-Commit-Position: refs/heads/master@{#372425}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/css3/flexbox/shrinking-column-flexbox.html View 1 chunk +52 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
cbiesinger
4 years, 10 months ago (2016-01-29 19:45:21 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1646413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1646413002/1
4 years, 10 months ago (2016-01-29 19:49:05 UTC) #3
cbiesinger
Adding some reviewers in a timezone where it's not Saturday...
4 years, 10 months ago (2016-01-29 19:49:14 UTC) #5
skobes
lgtm
4 years, 10 months ago (2016-01-29 19:58:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1646413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1646413002/1
4 years, 10 months ago (2016-01-29 20:11:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-29 21:26:09 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8b1f305aa32f871dd7dbda0da422adc63598ca3b Cr-Commit-Position: refs/heads/master@{#372425}
4 years, 10 months ago (2016-01-29 21:27:17 UTC) #14
leviw_travelin_and_unemployed
4 years, 10 months ago (2016-01-29 21:42:13 UTC) #15
Message was sent while issue was closed.
w00t.

LGTM.

Thanks, skobes :)

Powered by Google App Engine
This is Rietveld 408576698