Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 1646363002: Rename ReferenceKind.constField and referenceKind.staticMethod. (Closed)

Created:
4 years, 10 months ago by Paul Berry
Modified:
4 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rename ReferenceKind.constField and referenceKind.staticMethod. These will be re-used when summarizing inferred types, and they won't necessarily refer to things that are const/static. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/db4acee8c3060f711a86775ccd835a03b1160429

Patch Set 1 #

Patch Set 2 : Remove unintentional deletion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -30 lines) Patch
M pkg/analyzer/lib/src/summary/format.dart View 1 chunk +6 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/summary/prelink.dart View 1 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/summary/public_namespace_computer.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 10 chunks +11 lines, -11 lines 0 comments Download
M pkg/analyzer/tool/summary/idl.dart View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 10 months ago (2016-01-29 18:19:23 UTC) #2
scheglov
LGTM
4 years, 10 months ago (2016-01-29 18:22:53 UTC) #3
Paul Berry
4 years, 10 months ago (2016-01-29 18:34:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
db4acee8c3060f711a86775ccd835a03b1160429 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698