tools/json_schema_compiler/util_cc_helper.py - Issue 16462004: Add optional schema compiler error messages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/json_schema_compiler/util_cc_helper.py

Issue 16462004: Add optional schema compiler error messages Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Kalman's requests Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/json_schema_compiler/util_cc_helper.py

diff --git a/tools/json_schema_compiler/util_cc_helper.py b/tools/json_schema_compiler/util_cc_helper.py

index 8d490ba5ba345877f1aea32a1765a5b3e9475985..df5b6de0f507444403bf16f86cbf6425f4d7f7fa 100644

--- a/tools/json_schema_compiler/util_cc_helper.py

+++ b/tools/json_schema_compiler/util_cc_helper.py

@@ -77,3 +77,9 @@ class UtilCCHelper(object):

def GetIncludePath(self):

return '#include "tools/json_schema_compiler/util.h"'

+ def GetValueTypeString(self, value, is_ptr=False):

+ call = '.GetType()'

+ if is_ptr:

+ call = '->GetType()'

+ return 'json_schema_compiler::util::ValueTypeToString(%s%s)' % (value, call)