Bring in a reduced/simplified version of Chromium's base::WeakPtr to //mojo/edk/util.

Bring in a reduced/simplified version of Chromium's base::WeakPtr to //mojo/edk/util.

Mostly, we just don't support SupportsWeakPtr.

R=jamesr@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/687ca35f95dd68a130bd6e5b54a7f58f99ae8e1d

[jamesr, 2016-01-28 23:56:55]

lgtm but please initialize your stack data in the tests

https://codereview.chromium.org/1646113002/diff/1/mojo/edk/util/weak_ptr.h
File mojo/edk/util/weak_ptr.h (right):

https://codereview.chromium.org/1646113002/diff/1/mojo/edk/util/weak_ptr.h#ne...
mojo/edk/util/weak_ptr.h:85: // result is definitive on threads other than the
"originating"
I think this is untrue - any return value is potentially bogus.

https://codereview.chromium.org/1646113002/diff/1/mojo/edk/util/weak_ptr_unit...
File mojo/edk/util/weak_ptr_unittest.cc (right):

https://codereview.chromium.org/1646113002/diff/1/mojo/edk/util/weak_ptr_unit...
mojo/edk/util/weak_ptr_unittest.cc:16: int data;
plz initialize to some value kthx

https://codereview.chromium.org/1646113002/diff/1/mojo/edk/util/weak_ptr_unit...
mojo/edk/util/weak_ptr_unittest.cc:127: Derived data;
|member| is uninit here. data = {}; should work, or give it an initializer

[viettrungluu, 2016-01-29 00:03:40]

https://codereview.chromium.org/1646113002/diff/1/mojo/edk/util/weak_ptr.h
File mojo/edk/util/weak_ptr.h (right):

https://codereview.chromium.org/1646113002/diff/1/mojo/edk/util/weak_ptr.h#ne...
mojo/edk/util/weak_ptr.h:85: // result is definitive on threads other than the
"originating"
On 2016/01/28 23:56:55, jamesr wrote:
> I think this is untrue - any return value is potentially bogus.

Oops, comment removed.

https://codereview.chromium.org/1646113002/diff/1/mojo/edk/util/weak_ptr_unit...
File mojo/edk/util/weak_ptr_unittest.cc (right):

https://codereview.chromium.org/1646113002/diff/1/mojo/edk/util/weak_ptr_unit...
mojo/edk/util/weak_ptr_unittest.cc:16: int data;
On 2016/01/28 23:56:55, jamesr wrote:
> plz initialize to some value kthx

Done.

https://codereview.chromium.org/1646113002/diff/1/mojo/edk/util/weak_ptr_unit...
mojo/edk/util/weak_ptr_unittest.cc:127: Derived data;
On 2016/01/28 23:56:55, jamesr wrote:
> |member| is uninit here. data = {}; should work, or give it an initializer

Done.

[viettrungluu, 2016-01-29 00:03:53]

Description was changed from

==========
Bring in a reduced/simplified version of Chromium's base::WeakPtr to
//mojo/edk/util.

Mostly, we just don't support SupportsWeakPtr.

R=jamesr@chromium.org
==========

to

==========
Bring in a reduced/simplified version of Chromium's base::WeakPtr to
//mojo/edk/util.

Mostly, we just don't support SupportsWeakPtr.

R=jamesr@chromium.org

Committed:
https://chromium.googlesource.com/external/mojo/+/687ca35f95dd68a130bd6e5b54a...
==========

[viettrungluu, 2016-01-29 00:03:55]

Committed patchset #2 (id:20001) manually as
687ca35f95dd68a130bd6e5b54a7f58f99ae8e1d (presubmit successful).