Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1646083002: Disable RenderViewImplTest.NavigateProxyAndDetachBeforeOnNavigate. (Closed)

Created:
4 years, 10 months ago by Charlie Reis
Modified:
4 years, 10 months ago
Reviewers:
alexmos
CC:
chromium-reviews, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable RenderViewImplTest.NavigateProxyAndDetachBeforeOnNavigate. This test started failing on the Site Isolation FYI bots after https://codereview.chromium.org/1645923002/. This CL disables it there until we can fix it. The test is a no-op on other bots without the --site-per-process flag. BUG=582251 TEST=Site Isolation FYI bots go green. Committed: https://crrev.com/09dbf9a26c524f3efd62aba74aff70a8a0c57a39 Cr-Commit-Position: refs/heads/master@{#372218}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M testing/buildbot/filters/site-per-process.content_browsertests.filter View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1646083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1646083002/1
4 years, 10 months ago (2016-01-28 23:08:16 UTC) #2
Charlie Reis
Alex, do you think we should disable this or go for a quick fix?
4 years, 10 months ago (2016-01-28 23:15:36 UTC) #4
alexmos
LGTM
4 years, 10 months ago (2016-01-28 23:18:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1646083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1646083002/1
4 years, 10 months ago (2016-01-28 23:21:08 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-29 00:28:30 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-01-29 00:29:17 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/09dbf9a26c524f3efd62aba74aff70a8a0c57a39
Cr-Commit-Position: refs/heads/master@{#372218}

Powered by Google App Engine
This is Rietveld 408576698