src/IceInstARM32.cpp - Issue 1646033002: ARM32 vector mul

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceInstARM32.cpp

Issue 1646033002: ARM32 vector mul (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/IceInstARM32.cpp

diff --git a/src/IceInstARM32.cpp b/src/IceInstARM32.cpp

index aa6f00f7ca3efdae6be9aa60bb0f2759c1c31143..f288c89b4c4c8444f308f632c6bad919e6391959 100644

--- a/src/IceInstARM32.cpp

+++ b/src/IceInstARM32.cpp

@@ -703,13 +703,15 @@ template <> void InstARM32Vmul::emitIAS(const Cfg *Func) const {

switch (Dest->getType()) {

default:

// TODO(kschimpf) Figure if more cases are needed.

- Asm->setNeedsTextFixup();

+ emitUsingTextFixup(Func);

break;

case IceType_f32:

Asm->vmuls(getDest(), getSrc(0), getSrc(1), CondARM32::AL);

+ assert(!Asm->needsTextFixup());

break;

case IceType_f64:

Asm->vmuld(getDest(), getSrc(0), getSrc(1), CondARM32::AL);

+ assert(!Asm->needsTextFixup());

break;

}

assert(!Asm->needsTextFixup());

Karl 2016/01/28 21:16:14 I would remove this, since it doesn't appear to ad

« no previous file with comments | « no previous file | src/IceTargetLoweringARM32.cpp » ('j') | no next file with comments »