Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1646033002: ARM32 vector mul (Closed)

Created:
4 years, 10 months ago by Eric Holk
Modified:
4 years, 10 months ago
Reviewers:
sehr, Karl, Jim Stichnoth, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -2 lines) Patch
M src/IceInstARM32.cpp View 1 chunk +3 lines, -1 line 1 comment Download
M src/IceTargetLoweringARM32.cpp View 2 chunks +7 lines, -1 line 0 comments Download
A tests_lit/assembler/arm32/mul-vec.ll View 1 chunk +85 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Eric Holk
4 years, 10 months ago (2016-01-28 21:10:50 UTC) #2
Karl
LGTM except for nits. https://codereview.chromium.org/1646033002/diff/1/src/IceInstARM32.cpp File src/IceInstARM32.cpp (right): https://codereview.chromium.org/1646033002/diff/1/src/IceInstARM32.cpp#newcode717 src/IceInstARM32.cpp:717: assert(!Asm->needsTextFixup()); I would remove this, ...
4 years, 10 months ago (2016-01-28 21:16:15 UTC) #3
Eric Holk
Committed patchset #1 (id:1) manually as 029bed9c6b82366561722e7f8db17d7c7254a57c (presubmit successful).
4 years, 10 months ago (2016-01-28 21:38:46 UTC) #5
Eric Holk
4 years, 10 months ago (2016-01-28 21:41:12 UTC) #6
Message was sent while issue was closed. 
On 2016/01/28 21:16:15, Karl wrote:
> LGTM except for nits.
> 
> https://codereview.chromium.org/1646033002/diff/1/src/IceInstARM32.cpp
> File src/IceInstARM32.cpp (right):
> 
>
https://codereview.chromium.org/1646033002/diff/1/src/IceInstARM32.cpp#newcod...
> src/IceInstARM32.cpp:717: assert(!Asm->needsTextFixup());
> I would remove this, since it doesn't appear to add any value.

I forgot to fix the nits. I'll include them in my next CL.

Powered by Google App Engine
This is Rietveld 408576698