Issue 1645933002: dart2js CPS: During shrinking reductions, mark deleted branches as deleted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1645933002: dart2js CPS: During shrinking reductions, mark deleted branches as deleted. (Closed)

Created:
4 years, 10 months ago by Kevin Millikin (Google)

Modified:
4 years, 10 months ago

Reviewers:
asgerf

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

dart2js CPS: During shrinking reductions, mark deleted branches as deleted. Shrinking reductions uses a null parent of a potential redex to detect that the redex occurs in an already-deleted subterm, to avoid performing such reductions. (They are not safe because the term structure of deleted subterms, e.g., use lists, might not be consistent.) R=asgerf@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/7db0c89e49f6618059afa43d49da3730e942b82c

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Kevin Millikin (Google)

4 years, 10 months ago (2016-01-28 09:00:12 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7db0c89e49f6618059afa43d49da3730e942b82c (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages