third_party/WebKit/Source/platform/fonts/Character.h - Issue 1645893002: Improve performance of Character::isCJKIdeographOrSymbol by using trie tree

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/Character.h

Issue 1645893002: Improve performance of Character::isCJKIdeographOrSymbol by using trie tree (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: asan/msan/tsan build fix Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/blink_platform.gyp ('k') | third_party/WebKit/Source/platform/fonts/Character.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/Character.h

diff --git a/third_party/WebKit/Source/platform/fonts/Character.h b/third_party/WebKit/Source/platform/fonts/Character.h

index 6b4477dd60f535965686b8ef2ebf32debce63772..091d8851a399f34eebbac69e2e94445757be4719 100644

--- a/third_party/WebKit/Source/platform/fonts/Character.h

+++ b/third_party/WebKit/Source/platform/fonts/Character.h

@@ -32,6 +32,7 @@

#define Character_h

#include "platform/PlatformExport.h"

+#include "platform/fonts/CharacterProperty.h"

#include "platform/text/TextDirection.h"

#include "platform/text/TextPath.h"

#include "platform/text/TextRun.h"

@@ -61,7 +62,6 @@ public:

|| isInRange(character, 0xE0100, 0xE01EF); // VARIATION SELECTOR-17 to 256

}

- static bool isCJKIdeograph(UChar32);

static bool isCJKIdeographOrSymbol(UChar32);

static unsigned expansionOpportunityCount(const LChar*, size_t length, TextDirection, bool& isAfterExpansion, const TextJustify);

@@ -132,6 +132,8 @@ public:

static bool isCommonOrInheritedScript(UChar32);

+private:

+ static bool hasProperty(UChar32, CharacterProperty);

};

} // namespace blink

« no previous file with comments | « third_party/WebKit/Source/platform/blink_platform.gyp ('k') | third_party/WebKit/Source/platform/fonts/Character.cpp » ('j') | no next file with comments »