Decoded command-line inputs to Unicode strings. Resolves #24.

Decoded command-line inputs to Unicode strings. Resolves #24.

https://github.com/chromium/caterpillar/issues/24

R=mgiuca@chromium.org

Committed: 66b1252a03d48f189cce2ece643627e395fbb0ab

[Matthew Alger, 2016-01-29 01:35:48]

alger@google.com changed reviewers:
+ mgiuca@chromium.org

[Matthew Alger, 2016-01-29 01:35:48]

os.walk behaves differently depending on whether its arguments are str or
unicode, and output_dir was str, so all filepaths were str leading to
str/unicode conflicts. This CL resolves that problem.

[Matt Giuca, 2016-01-29 02:46:25]

It's not clear how this fixes the bug described. (This seems to fix unicode
inputs on the command line; the bug describes unicode filenames in a JSON.)

https://codereview.chromium.org/1645873003/diff/1/src/caterpillar.py
File src/caterpillar.py (right):

https://codereview.chromium.org/1645873003/diff/1/src/caterpillar.py#newcode726
src/caterpillar.py:726: type=unicode_arg)
Indent

[Matthew Alger, 2016-01-29 02:51:18]

The config file in the issue generates a boilerplate directory which has a
non-ASCII filename. The boilerplate directory is then cached by the service
worker. When the service worker generates the cache, it walks all of the files
in the output directory - including the boilerplate directory, since this should
also be cached - and writes them to the service worker JS file. The type of the
filenames produced while walking depends on the type of the output directory
which is read from the command line. This CL decodes the command-line arguments
to Unicode strings, hence fixing the bug.

https://codereview.chromium.org/1645873003/diff/1/src/caterpillar.py
File src/caterpillar.py (right):

https://codereview.chromium.org/1645873003/diff/1/src/caterpillar.py#newcode726
src/caterpillar.py:726: type=unicode_arg)
On 2016/01/29 02:46:25, Matt Giuca wrote:
> Indent

Done.

[Matt Giuca, 2016-01-29 03:08:17]

On 2016/01/29 02:51:18, Matthew Alger wrote:
> The config file in the issue generates a boilerplate directory which has a
> non-ASCII filename. The boilerplate directory is then cached by the service
> worker. When the service worker generates the cache, it walks all of the files
> in the output directory - including the boilerplate directory, since this
should
> also be cached - and writes them to the service worker JS file. The type of
the
> filenames produced while walking depends on the type of the output directory
> which is read from the command line. This CL decodes the command-line
arguments
> to Unicode strings, hence fixing the bug.

O_O!

OK good work. This is why we want to standardize on one string type :)

ltgm

> 
> https://codereview.chromium.org/1645873003/diff/1/src/caterpillar.py
> File src/caterpillar.py (right):
> 
>
https://codereview.chromium.org/1645873003/diff/1/src/caterpillar.py#newcode726
> src/caterpillar.py:726: type=unicode_arg)
> On 2016/01/29 02:46:25, Matt Giuca wrote:
> > Indent
> 
> Done.

[Matt Giuca, 2016-01-29 03:08:26]

lgtm

[Matthew Alger, 2016-01-29 04:11:29]

Description was changed from

==========
Decoded command-line inputs to Unicode strings. Resolves #24.

https://github.com/chromium/caterpillar/issues/24
==========

to

==========
Decoded command-line inputs to Unicode strings. Resolves #24.

https://github.com/chromium/caterpillar/issues/24

R=mgiuca@chromium.org

Committed: 66b1252a03d48f189cce2ece643627e395fbb0ab
==========

[Matthew Alger, 2016-01-29 04:11:31]

Committed patchset #3 (id:40001) manually as
66b1252a03d48f189cce2ece643627e395fbb0ab (presubmit successful).