Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: content/common/gpu/media/gpu_video_decode_accelerator.cc

Issue 1645873002: Use ParamTraits for media::BitstreamBuffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix compiling errors on mac and address review comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/gpu/media/gpu_video_decode_accelerator.cc
diff --git a/content/common/gpu/media/gpu_video_decode_accelerator.cc b/content/common/gpu/media/gpu_video_decode_accelerator.cc
index d70b5eee80fb77ac2abbdeed01d720a9e4a102ad..682ddc3fea8f50d3f0a9c45aa6b8f9b9136eb10a 100644
--- a/content/common/gpu/media/gpu_video_decode_accelerator.cc
+++ b/content/common/gpu/media/gpu_video_decode_accelerator.cc
@@ -492,31 +492,8 @@ void GpuVideoDecodeAccelerator::OnSetCdm(int cdm_id) {
// Runs on IO thread if video_decode_accelerator_->CanDecodeOnIOThread() is
// true, otherwise on the main thread.
void GpuVideoDecodeAccelerator::OnDecode(
- const AcceleratedVideoDecoderMsg_Decode_Params& params) {
+ const media::BitstreamBuffer& bitstream_buffer) {
DCHECK(video_decode_accelerator_);
- if (params.bitstream_buffer_id < 0) {
- DLOG(ERROR) << "BitstreamBuffer id " << params.bitstream_buffer_id
- << " out of range";
- if (child_task_runner_->BelongsToCurrentThread()) {
- NotifyError(media::VideoDecodeAccelerator::INVALID_ARGUMENT);
- } else {
- child_task_runner_->PostTask(
- FROM_HERE,
- base::Bind(&GpuVideoDecodeAccelerator::NotifyError,
- base::Unretained(this),
- media::VideoDecodeAccelerator::INVALID_ARGUMENT));
- }
- return;
- }
-
- media::BitstreamBuffer bitstream_buffer(params.bitstream_buffer_id,
- params.buffer_handle, params.size,
- params.presentation_timestamp);
- if (!params.key_id.empty()) {
- bitstream_buffer.SetDecryptConfig(
- media::DecryptConfig(params.key_id, params.iv, params.subsamples));
- }
-
video_decode_accelerator_->Decode(bitstream_buffer);
}

Powered by Google App Engine
This is Rietveld 408576698