Use ParamTraits for media::BitstreamBuffer.

content/common/gpu/client/gpu_video_decode_accelerator_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/gpu/client/gpu_video_decode_accelerator_host.h"
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/message_loop/message_loop.h"
 #include "build/build_config.h"
@@ skipping 101 matching lines @@
   if (!channel_)
     return;
   Send(new AcceleratedVideoDecoderMsg_SetCdm(decoder_route_id_, cdm_id));
 }
 
 void GpuVideoDecodeAcceleratorHost::Decode(
     const media::BitstreamBuffer& bitstream_buffer) {
   DCHECK(CalledOnValidThread());
   if (!channel_)
     return;
-
-  base::SharedMemoryHandle handle = channel_->ShareToGpuProcess(
-      bitstream_buffer.handle());
+  media::BitstreamBuffer buffer_to_send = bitstream_buffer;
+  base::SharedMemoryHandle handle =

[dcheng, 2016/02/18 21:06:09]

I think the IPC subsystem has been improved so you don't need to explicitly dupe
anymore, but erikchen@ should confirm.

[erikchen, 2016/02/18 21:07:31]

correct. no need to dupe shared memory handles before passing them to ipc.

[Owen Lin, 2016/02/23 03:40:11]

Thanks. That's great. But I think we should do that in anther CL where I am
going to remove the function GpuChannelHost::ShareToGpuProcess(), since it is
not needed.

+      channel_->ShareToGpuProcess(bitstream_buffer.handle());
   if (!base::SharedMemory::IsHandleValid(handle)) {
     NOTREACHED() << "Failed to duplicate buffer handler";
     return;
   }
-
-  AcceleratedVideoDecoderMsg_Decode_Params params;
-  params.bitstream_buffer_id = bitstream_buffer.id();
-  params.buffer_handle = handle;
-  params.size = bitstream_buffer.size();
-  params.presentation_timestamp = bitstream_buffer.presentation_timestamp();
-  params.key_id = bitstream_buffer.key_id();
-  params.iv = bitstream_buffer.iv();
-  params.subsamples = bitstream_buffer.subsamples();
-
-  Send(new AcceleratedVideoDecoderMsg_Decode(decoder_route_id_, params));
+  buffer_to_send.set_handle(handle);
+  Send(
+      new AcceleratedVideoDecoderMsg_Decode(decoder_route_id_, buffer_to_send));
 }
 
 void GpuVideoDecodeAcceleratorHost::AssignPictureBuffers(
     const std::vector<media::PictureBuffer>& buffers) {
   DCHECK(CalledOnValidThread());
   if (!channel_)
     return;
   // Rearrange data for IPC command.
   std::vector<int32_t> buffer_ids;
   std::vector<uint32_t> texture_ids;
@@ skipping 133 matching lines @@
   weak_this_factory_.InvalidateWeakPtrs();
 
   // Client::NotifyError() may Destroy() |this|, so calling it needs to be the
   // last thing done on this stack!
   media::VideoDecodeAccelerator::Client* client = NULL;
   std::swap(client, client_);
   client->NotifyError(static_cast<media::VideoDecodeAccelerator::Error>(error));
 }
 
 }  // namespace content