Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 1645853003: base: Add scope support to context trace events (Closed)

Created:
4 years, 10 months ago by Sami
Modified:
4 years, 10 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

base: Add scope support to context trace events Make it possible to use context ids that are specific to a scope. BUG=546021 Committed: https://crrev.com/8f01592f0b53ed7a1a509faf6730e9b699a27abc Cr-Commit-Position: refs/heads/master@{#372967}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -10 lines) Patch
M base/trace_event/common/trace_event_common.h View 1 chunk +2 lines, -1 line 0 comments Download
M base/trace_event/trace_event.h View 1 3 chunks +3 lines, -5 lines 0 comments Download
M base/trace_event/trace_event_unittest.cc View 5 chunks +13 lines, -4 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
Sami
PTAL. FYI, Ehsan, we'll need a similar patch to Blink once we have scope support ...
4 years, 10 months ago (2016-01-28 18:51:03 UTC) #3
chiniforooshan
Just one question. https://codereview.chromium.org/1645853003/diff/1/base/trace_event/trace_event.h File base/trace_event/trace_event.h (right): https://codereview.chromium.org/1645853003/diff/1/base/trace_event/trace_event.h#newcode943 base/trace_event/trace_event.h:943: using TraceContext = trace_event_internal::TraceID; Where is ...
4 years, 10 months ago (2016-01-28 20:19:23 UTC) #4
Sami
https://codereview.chromium.org/1645853003/diff/1/base/trace_event/trace_event.h File base/trace_event/trace_event.h (right): https://codereview.chromium.org/1645853003/diff/1/base/trace_event/trace_event.h#newcode943 base/trace_event/trace_event.h:943: using TraceContext = trace_event_internal::TraceID; On 2016/01/28 20:19:23, chiniforooshan wrote: ...
4 years, 10 months ago (2016-02-01 17:45:58 UTC) #5
chiniforooshan
On 2016/02/01 17:45:58, Sami wrote: > https://codereview.chromium.org/1645853003/diff/1/base/trace_event/trace_event.h > File base/trace_event/trace_event.h (right): > > https://codereview.chromium.org/1645853003/diff/1/base/trace_event/trace_event.h#newcode943 > ...
4 years, 10 months ago (2016-02-01 17:53:49 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1645853003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1645853003/20001
4 years, 10 months ago (2016-02-02 11:27:06 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/16856)
4 years, 10 months ago (2016-02-02 14:45:48 UTC) #10
Sami
Thanks Ehsan. Dan, wanna stamp this?
4 years, 10 months ago (2016-02-02 15:27:40 UTC) #11
dsinclair
rs lgtm
4 years, 10 months ago (2016-02-02 15:44:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1645853003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1645853003/20001
4 years, 10 months ago (2016-02-02 15:57:14 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-02 17:15:38 UTC) #16
commit-bot: I haz the power
4 years, 10 months ago (2016-02-02 17:16:53 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8f01592f0b53ed7a1a509faf6730e9b699a27abc
Cr-Commit-Position: refs/heads/master@{#372967}

Powered by Google App Engine
This is Rietveld 408576698