Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Issue 1645843004: [BinarySize] Filter duplicate lines in nm output. (Closed)

Created:
4 years, 10 months ago by Daniel Bratell
Modified:
4 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[BinarySize] Filter duplicate lines in nm output. nm just outputs the symbols it finds in the debug sections of the binary and sometimes the same symbol appears more than once, with the exact same data. The binary_size tool would think that it was two different symbols that shared the same address so it would get the numbers right, but the output would be confusing since the memory would be split in two halves. BUG= Committed: https://crrev.com/9a8e892c20f14492af3cade9c6444de4e1267c1a Cr-Commit-Position: refs/heads/master@{#372359}

Patch Set 1 #

Patch Set 2 : Also add an OWNERS file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
A tools/binary_size/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download
M tools/binary_size/binary_size_utils.py View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Daniel Bratell
Can you please take a look? Just something I noticed when trying to make sense ...
4 years, 10 months ago (2016-01-29 13:21:13 UTC) #2
Andrew Hayden (chromium.org)
On 2016/01/29 13:21:13, Daniel Bratell wrote: > Can you please take a look? Just something ...
4 years, 10 months ago (2016-01-29 13:41:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1645843004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1645843004/1
4 years, 10 months ago (2016-01-29 13:49:19 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/140469)
4 years, 10 months ago (2016-01-29 13:58:01 UTC) #7
Daniel Bratell
thakis, can you please take a look? The code is already reviewed but this tools ...
4 years, 10 months ago (2016-01-29 15:59:41 UTC) #9
Nico
rs-lgtm
4 years, 10 months ago (2016-01-29 16:04:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1645843004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1645843004/20001
4 years, 10 months ago (2016-01-29 16:26:27 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-01-29 16:49:11 UTC) #14
commit-bot: I haz the power
4 years, 10 months ago (2016-01-29 16:50:47 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9a8e892c20f14492af3cade9c6444de4e1267c1a
Cr-Commit-Position: refs/heads/master@{#372359}

Powered by Google App Engine
This is Rietveld 408576698