chrome/browser/notifications/message_center_notification_manager.cc - Issue 1645843003: Implement Non-Closable Notification

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/message_center_notification_manager.cc

Issue 1645843003: Implement Non-Closable Notification (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove unnecessary property. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/notifications/notifications_apitest.cc ('k') | chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac_interactive_uitest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/message_center_notification_manager.cc

diff --git a/chrome/browser/notifications/message_center_notification_manager.cc b/chrome/browser/notifications/message_center_notification_manager.cc

index 06ed30bca027efc0fe4a1f71e103415b94806ffa..da307bb49eb133bcc590b8e59f5dd7e72eb4f4d5 100644

--- a/chrome/browser/notifications/message_center_notification_manager.cc

+++ b/chrome/browser/notifications/message_center_notification_manager.cc

@@ -278,7 +278,8 @@ bool MessageCenterNotificationManager::CancelAllByProfile(

}

void MessageCenterNotificationManager::CancelAll() {

- message_center_->RemoveAllNotifications(/* by_user */ false);

+ message_center_->RemoveAllNotifications(

+ false /* by_user */, message_center::MessageCenter::RemoveType::ALL);

}

////////////////////////////////////////////////////////////////////////////////