ash/content/display/screen_orientation_controller_chromeos_unittest.cc - Issue 1645843003: Implement Non-Closable Notification

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/content/display/screen_orientation_controller_chromeos_unittest.cc

Issue 1645843003: Implement Non-Closable Notification (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove unnecessary property. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ash/accelerators/accelerator_controller_unittest.cc ('k') | ash/system/web_notification/web_notification_tray_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ash/content/display/screen_orientation_controller_chromeos_unittest.cc

diff --git a/ash/content/display/screen_orientation_controller_chromeos_unittest.cc b/ash/content/display/screen_orientation_controller_chromeos_unittest.cc

index 6ce5086cd31ded288406149064d2e13aaa2268aa..5a5b8ab3f61360865eb2ce590e55f9c5c903e1e7 100644

--- a/ash/content/display/screen_orientation_controller_chromeos_unittest.cc

+++ b/ash/content/display/screen_orientation_controller_chromeos_unittest.cc

@@ -437,7 +437,8 @@ TEST_F(ScreenOrientationControllerTest, BlockRotationNotifications) {

EXPECT_TRUE(message_center->HasPopupNotifications());

// Clear all notifications

- message_center->RemoveAllNotifications(false);

+ message_center->RemoveAllNotifications(

+ false /* by_user */, message_center::MessageCenter::RemoveType::ALL);

EXPECT_EQ(0u, message_center->NotificationCount());

EXPECT_FALSE(message_center->HasPopupNotifications());

@@ -456,7 +457,8 @@ TEST_F(ScreenOrientationControllerTest, BlockRotationNotifications) {

// Reset the screen rotation.

SetInternalDisplayRotation(gfx::Display::ROTATE_0);

// Clear all notifications

- message_center->RemoveAllNotifications(false);

+ message_center->RemoveAllNotifications(

+ false /* by_user */, message_center::MessageCenter::RemoveType::ALL);

ASSERT_NE(gfx::Display::ROTATE_180, GetCurrentInternalDisplayRotation());

ASSERT_EQ(0u, message_center->NotificationCount());

ASSERT_FALSE(message_center->HasPopupNotifications());