chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac_interactive_uitest.mm - Issue 1645843003: Implement Non-Closable Notification

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac_interactive_uitest.mm

Issue 1645843003: Implement Non-Closable Notification (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed the comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/message_center_notification_manager.cc ('k') | ui/message_center/fake_message_center.h » ('j') | ui/message_center/notification.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac_interactive_uitest.mm

diff --git a/chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac_interactive_uitest.mm b/chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac_interactive_uitest.mm

index 8ea62f2766cb2db2342c514f0d7cd247fe20b557..03d1be750ec4ad64006cbc244d8d027120d10125 100644

--- a/chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac_interactive_uitest.mm

+++ b/chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac_interactive_uitest.mm

@@ -95,7 +95,8 @@ IN_PROC_BROWSER_TEST_P(QuitWithAppsControllerInteractiveTest, QuitBehavior) {

// If notification was dismissed by click, show again on next quit.

notification->delegate()->Click();

- message_center->RemoveAllNotifications(false);

+ message_center->RemoveAllNotifications(

+ false /* by_user */, message_center::MessageCenter::RemoveType::ALL);

EXPECT_FALSE(controller->ShouldQuit());

EXPECT_TRUE(AppWindowRegistryUtil::IsAppWindowVisibleInAnyProfile(0));

notification = g_browser_process->notification_ui_manager()->FindById(

@@ -108,7 +109,8 @@ IN_PROC_BROWSER_TEST_P(QuitWithAppsControllerInteractiveTest, QuitBehavior) {

// If notification is closed by user, don't show it next time.

notification->delegate()->Close(true);

- message_center->RemoveAllNotifications(false);

+ message_center->RemoveAllNotifications(

+ false /* by_user */, message_center::MessageCenter::RemoveType::ALL);

EXPECT_FALSE(controller->ShouldQuit());

EXPECT_TRUE(AppWindowRegistryUtil::IsAppWindowVisibleInAnyProfile(0));

notification = g_browser_process->notification_ui_manager()->FindById(

@@ -150,7 +152,8 @@ IN_PROC_BROWSER_TEST_P(QuitWithAppsControllerInteractiveTest, QuitBehavior) {

app_window->web_contents());

notification->delegate()->ButtonClick(0);

destroyed_watcher.Wait();

- message_center->RemoveAllNotifications(false);

+ message_center->RemoveAllNotifications(

+ false /* by_user */, message_center::MessageCenter::RemoveType::ALL);

EXPECT_FALSE(AppWindowRegistryUtil::IsAppWindowVisibleInAnyProfile(0));

quit_observer.Wait();

}