chrome/browser/extensions/api/notifications/notifications_apitest.cc - Issue 1645843003: Implement Non-Closable Notification

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/notifications/notifications_apitest.cc

Issue 1645843003: Implement Non-Closable Notification (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed the comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ash/accelerators/accelerator_controller_unittest.cc ('K') | « ash/system/web_notification/web_notification_tray_unittest.cc ('k') | chrome/browser/notifications/message_center_notification_manager.cc » ('j') | ui/message_center/message_center.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/notifications/notifications_apitest.cc

diff --git a/chrome/browser/extensions/api/notifications/notifications_apitest.cc b/chrome/browser/extensions/api/notifications/notifications_apitest.cc

index ba9fe4407262c7b01644d9b7f6e986b8082f89db..2d0bd63c77e35339422b45fa162ea405c1e36752 100644

--- a/chrome/browser/extensions/api/notifications/notifications_apitest.cc

+++ b/chrome/browser/extensions/api/notifications/notifications_apitest.cc

@@ -146,12 +146,14 @@ IN_PROC_BROWSER_TEST_F(NotificationsApiTest, TestByUser) {

{

ResultCatcher catcher;

- g_browser_process->message_center()->RemoveAllNotifications(false);

+ g_browser_process->message_center()->RemoveAllNotifications(

+ false /* by_user */, message_center::MessageCenter::RemoveType::ALL);

EXPECT_TRUE(catcher.GetNextResult()) << catcher.message();

}

{

ResultCatcher catcher;

- g_browser_process->message_center()->RemoveAllNotifications(true);

+ g_browser_process->message_center()->RemoveAllNotifications(

+ true /* by_user */, message_center::MessageCenter::RemoveType::ALL);

EXPECT_TRUE(catcher.GetNextResult()) << catcher.message();

}