Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Side by Side Diff: ui/message_center/views/message_center_view.cc

Issue 1645843003: Implement Non-Closable Notification (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed the comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/message_center/views/message_center_view.h" 5 #include "ui/message_center/views/message_center_view.h"
6 6
7 #include <list> 7 #include <list>
8 #include <map> 8 #include <map>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 237 matching lines...) Expand 10 before | Expand all | Expand 10 after
248 } 248 }
249 settings_transition_animation_.reset(new gfx::MultiAnimation( 249 settings_transition_animation_.reset(new gfx::MultiAnimation(
250 parts, base::TimeDelta::FromMicroseconds(1000000 / kDefaultFrameRateHz))); 250 parts, base::TimeDelta::FromMicroseconds(1000000 / kDefaultFrameRateHz)));
251 settings_transition_animation_->set_delegate(this); 251 settings_transition_animation_->set_delegate(this);
252 settings_transition_animation_->set_continuous(false); 252 settings_transition_animation_->set_continuous(false);
253 settings_transition_animation_->Start(); 253 settings_transition_animation_->Start();
254 254
255 button_bar_->SetBackArrowVisible(visible); 255 button_bar_->SetBackArrowVisible(visible);
256 } 256 }
257 257
258 void MessageCenterView::ClearAllNotifications() { 258 void MessageCenterView::ClearAllClosableNotifications() {
259 if (is_closing_) 259 if (is_closing_)
260 return; 260 return;
261 261
262 SetViewHierarchyEnabled(scroller_, false); 262 SetViewHierarchyEnabled(scroller_, false);
263 button_bar_->SetAllButtonsEnabled(false); 263 button_bar_->SetAllButtonsEnabled(false);
264 message_list_view_->ClearAllNotifications(scroller_->GetVisibleRect()); 264 message_list_view_->ClearAllClosableNotifications(
265 scroller_->GetVisibleRect());
265 } 266 }
266 267
267 void MessageCenterView::OnAllNotificationsCleared() { 268 void MessageCenterView::OnAllNotificationsCleared() {
268 SetViewHierarchyEnabled(scroller_, true); 269 SetViewHierarchyEnabled(scroller_, true);
269 button_bar_->SetAllButtonsEnabled(true); 270 button_bar_->SetAllButtonsEnabled(true);
270 button_bar_->SetCloseAllButtonEnabled(false); 271 button_bar_->SetCloseAllButtonEnabled(false);
271 message_center_->RemoveAllVisibleNotifications(true); // Action by user. 272
273 // Action by user.
274 message_center_->RemoveAllNotifications(
275 true /* by_ser */, message_center::MessageCenter::RemoveType::CLOSABLE);
dewittj 2016/02/08 18:02:34 nit: by_user
yoshiki 2016/02/09 23:42:25 Done.
272 } 276 }
273 277
274 size_t MessageCenterView::NumMessageViewsForTest() const { 278 size_t MessageCenterView::NumMessageViewsForTest() const {
275 return message_list_view_->child_count(); 279 return message_list_view_->child_count();
276 } 280 }
277 281
278 void MessageCenterView::OnSettingsChanged() { 282 void MessageCenterView::OnSettingsChanged() {
279 scroller_->InvalidateLayout(); 283 scroller_->InvalidateLayout();
280 PreferredSizeChanged(); 284 PreferredSizeChanged();
281 Layout(); 285 Layout();
(...skipping 299 matching lines...) Expand 10 before | Expand all | Expand 10 after
581 View* focused_view = NULL; 585 View* focused_view = NULL;
582 // |focus_manager| can be NULL in tests. 586 // |focus_manager| can be NULL in tests.
583 if (focus_manager) 587 if (focus_manager)
584 focused_view = focus_manager->GetFocusedView(); 588 focused_view = focus_manager->GetFocusedView();
585 589
586 // All the children of this view are owned by |this|. 590 // All the children of this view are owned by |this|.
587 scroller_->contents()->RemoveAllChildViews(/*delete_children=*/false); 591 scroller_->contents()->RemoveAllChildViews(/*delete_children=*/false);
588 scroller_->contents()->AddChildView( 592 scroller_->contents()->AddChildView(
589 no_message_views ? empty_list_view_.get() : message_list_view_.get()); 593 no_message_views ? empty_list_view_.get() : message_list_view_.get());
590 594
591 button_bar_->SetCloseAllButtonEnabled(!no_message_views); 595 bool no_closable_views = true;
596 for (const auto& view : notification_views_) {
597 if (view.second->IsClosable()) {
598 no_closable_views = false;
599 break;
600 }
601 }
602 button_bar_->SetCloseAllButtonEnabled(!no_closable_views);
592 scroller_->SetFocusable(!no_message_views); 603 scroller_->SetFocusable(!no_message_views);
593 604
594 if (focus_manager && focused_view) 605 if (focus_manager && focused_view)
595 focus_manager->SetFocusedView(focused_view); 606 focus_manager->SetFocusedView(focused_view);
596 607
597 scroller_->InvalidateLayout(); 608 scroller_->InvalidateLayout();
598 PreferredSizeChanged(); 609 PreferredSizeChanged();
599 Layout(); 610 Layout();
600 } 611 }
601 612
602 void MessageCenterView::SetNotificationViewForTest(MessageView* view) { 613 void MessageCenterView::SetNotificationViewForTest(MessageView* view) {
603 message_list_view_->AddNotificationAt(view, 0); 614 message_list_view_->AddNotificationAt(view, 0);
604 } 615 }
605 616
606 } // namespace message_center 617 } // namespace message_center
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698