Implement Non-Closable Notification

ui/message_center/message_center.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_MESSAGE_CENTER_MESSAGE_CENTER_H_
 #define UI_MESSAGE_CENTER_MESSAGE_CENTER_H_
 
 #include <stddef.h>
 
 #include <string>
@@ skipping 32 matching lines @@
 class MessagePopupCollectionTest;
 }
 
 class MessageCenterObserver;
 class MessageCenterImplTest;
 class NotificationBlocker;
 class NotifierSettingsProvider;
 
 class MESSAGE_CENTER_EXPORT MessageCenter {
  public:
+  enum class RemoveType {
+    // Remove all notifications (including invisible ones and unclosable ones).

[dewittj, 2016/02/08 18:02:34]

nit: remove the parenthetical phrase - I think |all| is clear enough.

[yoshiki, 2016/02/09 23:42:25]

Done.

+    ALL,
+    // Remove visible notifications including unclosable ones.
+    VISIBLE,

[dewittj, 2016/02/08 18:02:34]

This flag is only used in a test, why don't we just remove it.

[yoshiki, 2016/02/09 23:42:25]

Removed. Done.

+    // Remove closable notification (doesn't remove invisible ones).
+    CLOSABLE,

[dewittj, 2016/02/08 18:02:34]

These flag names are still confusing.  I don't have a great idea for naming, but
just reading the code where these flags are used I am not sure I would have an
accurate idea of what they actually do without reading the documentation here.

Possibly renaming the "closable" concept would be better.  Something like
"pinned" may convey the idea of keeping them around better?

[yoshiki, 2016/02/09 23:42:25]

Thank you for suggestion! Renamed this to "pinned".

+  };
+
   // Creates the global message center object.
   static void Initialize();
 
   // Returns the global message center object. Returns NULL if Initialize is not
   // called.
   static MessageCenter* Get();
 
   // Destroys the global message_center object.
   static void Shutdown();
 
@@ skipping 32 matching lines @@
   // Adds a new notification.
   virtual void AddNotification(scoped_ptr<Notification> notification) = 0;
 
   // Updates an existing notification with id = old_id and set its id to new_id.
   virtual void UpdateNotification(
       const std::string& old_id,
       scoped_ptr<Notification> new_notification) = 0;
 
   // Removes an existing notification.
   virtual void RemoveNotification(const std::string& id, bool by_user) = 0;
-  virtual void RemoveAllNotifications(bool by_user) = 0;
-  virtual void RemoveAllVisibleNotifications(bool by_user) = 0;
+  virtual void RemoveAllNotifications(bool by_user, RemoveType type) = 0;
 
   // Sets the icon image. Icon appears at the top-left of the notification.
   virtual void SetNotificationIcon(const std::string& notification_id,
                                    const gfx::Image& image) = 0;
 
   // Sets the large image for the notifications of type == TYPE_IMAGE. Specified
   // image will appear below of the notification.
   virtual void SetNotificationImage(const std::string& notification_id,
                                     const gfx::Image& image) = 0;
 
@@ skipping 88 matching lines @@
   // Note carefully: this may break the layout of message center. Shouldn't use
   // this method if the update changes its notification size.
   virtual void ForceNotificationFlush(const std::string& id) {}
 
   DISALLOW_COPY_AND_ASSIGN(MessageCenter);
 };
 
 }  // namespace message_center
 
 #endif  // UI_MESSAGE_CENTER_MESSAGE_CENTER_H_