Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issue 1645843002: Force a frame changed message (WM_NCCALCSIZE) to occur during settings change. (Closed)

Created:
4 years, 11 months ago by ananta
Modified:
4 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Force a frame changed message (WM_NCCALCSIZE) to occur during settings change. The WM_SETTINGCHANGE message is broadcasted to top level windows, in multiple cases, one of them being work area changes, which could occur due to taskbar settings change, i.e autohide to taskbar being turned off, etc. We need to ensure that we handle this correctly specifically for maximized windows, where in we don't want to draw over the taskbar. This is handled today in our WM_NCCALCSIZE handler. Forcing a WM_NCCALCSIZE message to occur in WM_SETTINGCHANGE fixes these problems. BUG=581779 Committed: https://crrev.com/08ed577be264f3a38d174379879109508491fc70 Cr-Commit-Position: refs/heads/master@{#372175}

Patch Set 1 #

Patch Set 2 : Remove newline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M ui/views/win/hwnd_message_handler.cc View 1 2 chunks +9 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (4 generated)
ananta
4 years, 11 months ago (2016-01-28 02:27:26 UTC) #2
sky
LGTM
4 years, 10 months ago (2016-01-28 16:24:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1645843002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1645843002/20001
4 years, 10 months ago (2016-01-28 20:54:14 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-01-28 21:41:38 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 21:42:43 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/08ed577be264f3a38d174379879109508491fc70
Cr-Commit-Position: refs/heads/master@{#372175}

Powered by Google App Engine
This is Rietveld 408576698