Issue 164583002: Merge 249937 "Linux Sandbox: Stop GPU watchdog in accountable way."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164583002: Merge 249937 "Linux Sandbox: Stop GPU watchdog in accountable way." (Closed)

Created:
6 years, 10 months ago by jln (very slow on Chromium)

Modified:
6 years, 10 months ago

Reviewers:
jln (very slow on Chromium)

CC:
chromium-reviews, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, agl, jln+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1750/src/

Visibility:
Public.

More Reviews

Description

Merge 249937 "Linux Sandbox: Stop GPU watchdog in accountable way." > Linux Sandbox: Stop GPU watchdog in accountable way. > > The Linux sandbox can sometimes detect a spurious running thread if it > has just been stopped. > > We add a new LinuxSandbox::StopThread() method to safely stop threads > and make sure they won't be counted as still running. > > BUG=328620 > NOTRY=true > > Review URL: https://codereview.chromium.org/147203005 TBR=jln@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251107

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+87 lines, -27 lines)			Patch
M	content/common/sandbox_linux/sandbox_linux.h	View	3 chunks	+14 lines, -3 lines	0 comments	Download
M	content/common/sandbox_linux/sandbox_linux.cc	View	9 chunks	+66 lines, -24 lines	0 comments	Download
M	content/gpu/gpu_main.cc	View	1 chunk	+7 lines, -3 lines	0 comments	Download
M	sandbox/linux/sandbox_linux.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	sandbox/linux/sandbox_linux_test_sources.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
A +	sandbox/linux/services/thread_helpers.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	sandbox/linux/services/thread_helpers.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	sandbox/linux/services/thread_helpers_unittests.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jln (very slow on Chromium)

6 years, 10 months ago (2014-02-13 20:14:53 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r251107.

Expand Messages | Collapse Messages