Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1645823002: Change gpu setting for emulator run with no ui (Closed)

Created:
4 years, 10 months ago by Yoland Yan(Google)
Modified:
4 years, 10 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change gpu setting for emulator run with no ui BUG= Committed: https://crrev.com/5b685e2f6ec533187d6f93c6323ff90bd17c8a93 Cr-Commit-Position: refs/heads/master@{#371988}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M build/android/pylib/utils/emulator.py View 3 chunks +6 lines, -3 lines 1 comment Download

Messages

Total messages: 9 (3 generated)
Yoland Yan(Google)
4 years, 10 months ago (2016-01-28 01:15:47 UTC) #2
jbudorick
lgtm https://codereview.chromium.org/1645823002/diff/1/build/android/pylib/utils/emulator.py File build/android/pylib/utils/emulator.py (right): https://codereview.chromium.org/1645823002/diff/1/build/android/pylib/utils/emulator.py#newcode65 build/android/pylib/utils/emulator.py:65: CONFIG_REPLACEMENTS = { I think this should be ...
4 years, 10 months ago (2016-01-28 01:22:07 UTC) #3
Yoland Yan(Google)
4 years, 10 months ago (2016-01-28 01:22:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1645823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1645823002/1
4 years, 10 months ago (2016-01-28 01:41:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-28 03:22:35 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 03:24:25 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5b685e2f6ec533187d6f93c6323ff90bd17c8a93
Cr-Commit-Position: refs/heads/master@{#371988}

Powered by Google App Engine
This is Rietveld 408576698