Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1645803003: SkPDF: roll back 53b1c09 and 05b48e2 (Closed)

Created:
4 years, 10 months ago by hal.canary
Modified:
4 years, 10 months ago
Reviewers:
tomhudson
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -111 lines) Patch
M src/pdf/SkPDFDevice.cpp View 9 chunks +13 lines, -111 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1645803003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1645803003/1
4 years, 10 months ago (2016-01-28 18:11:17 UTC) #4
hal.canary
PTAL
4 years, 10 months ago (2016-01-28 18:11:53 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-01-28 18:22:29 UTC) #8
tomhudson
lgtm Nit: skia:734 is probably not the bug you meant to cite.
4 years, 10 months ago (2016-01-28 18:58:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1645803003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1645803003/1
4 years, 10 months ago (2016-01-28 18:58:48 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 18:59:37 UTC) #13
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/682ee016a35c73803d4e4b46a7c4c9486807a9a5

Powered by Google App Engine
This is Rietveld 408576698