Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1645773002: Clarify telemetry presubmit warning. (Closed)

Created:
4 years, 10 months ago by aiolos (Not reviewing)
Modified:
4 years, 10 months ago
Reviewers:
eakuefner, nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clarify telemetry presubmit warning. BUG=478864 nopresubmit=true Committed: https://crrev.com/a5f65447d633db267e473cc26dbbbfbf866035e1 Cr-Commit-Position: refs/heads/master@{#371912}

Patch Set 1 #

Total comments: 2

Patch Set 2 : add deletion date. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M tools/telemetry/PRESUBMIT.py View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
aiolos (Not reviewing)
People are getting confused by telemetry being "temporarily read-only" since this implies that it will ...
4 years, 10 months ago (2016-01-27 22:30:38 UTC) #3
nednguyen
lgtm https://codereview.chromium.org/1645773002/diff/1/tools/telemetry/PRESUBMIT.py File tools/telemetry/PRESUBMIT.py (right): https://codereview.chromium.org/1645773002/diff/1/tools/telemetry/PRESUBMIT.py#newcode32 tools/telemetry/PRESUBMIT.py:32: 'scheduled for deletion.' I think the deletion day ...
4 years, 10 months ago (2016-01-27 22:33:25 UTC) #4
aiolos (Not reviewing)
https://codereview.chromium.org/1645773002/diff/1/tools/telemetry/PRESUBMIT.py File tools/telemetry/PRESUBMIT.py (right): https://codereview.chromium.org/1645773002/diff/1/tools/telemetry/PRESUBMIT.py#newcode32 tools/telemetry/PRESUBMIT.py:32: 'scheduled for deletion.' On 2016/01/27 22:33:24, nednguyen wrote: > ...
4 years, 10 months ago (2016-01-27 22:37:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1645773002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1645773002/20001
4 years, 10 months ago (2016-01-27 22:40:05 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-01-28 00:11:16 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 00:13:31 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/a5f65447d633db267e473cc26dbbbfbf866035e1
Cr-Commit-Position: refs/heads/master@{#371912}

Powered by Google App Engine
This is Rietveld 408576698