tools/clang/blink_gc_plugin/RecordInfo.cpp - Issue 1645763004: blink_gc_plugin: Make RecordInfo::Get{Fields,Bases} return deterministic order

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/RecordInfo.cpp

Issue 1645763004: blink_gc_plugin: Make RecordInfo::Get{Fields,Bases} return deterministic order (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert the old fix attempt Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/clang/blink_gc_plugin/RecordInfo.cpp

diff --git a/tools/clang/blink_gc_plugin/RecordInfo.cpp b/tools/clang/blink_gc_plugin/RecordInfo.cpp

index 3c166dd4c431374f32ff2851d01654c82d7a805a..b4937abd20f55a45757302c9d7f007d25de733e2 100644

--- a/tools/clang/blink_gc_plugin/RecordInfo.cpp

+++ b/tools/clang/blink_gc_plugin/RecordInfo.cpp

@@ -399,7 +399,7 @@ RecordInfo::Bases* RecordInfo::CollectBases() {

TracingStatus status = info->InheritsTrace()

? TracingStatus::Needed()

: TracingStatus::Unneeded();

- bases->insert(std::make_pair(base, BasePoint(spec, info, status)));

+ bases->push_back(std::make_pair(base, BasePoint(spec, info, status)));

}

return bases;

}

« no previous file with comments | « tools/clang/blink_gc_plugin/RecordInfo.h ('k') | no next file » | no next file with comments »