Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1046)

Unified Diff: test/cctest/interpreter/test-bytecode-generator.cc

Issue 1645763003: [Interpreter] TurboFan implementation of intrinsics. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/interpreter/test-bytecode-generator.cc
diff --git a/test/cctest/interpreter/test-bytecode-generator.cc b/test/cctest/interpreter/test-bytecode-generator.cc
index b730fa63ebe15a0ff2f637a3da14b19dda0cc968..80ffe97885430f14d1d3c78a4ac1baefc4cc372b 100644
--- a/test/cctest/interpreter/test-bytecode-generator.cc
+++ b/test/cctest/interpreter/test-bytecode-generator.cc
@@ -1792,15 +1792,15 @@ TEST(CallRuntime) {
},
},
{
- "function f(a) { return %IsArray(a) }\nf(undefined)",
+ "function f(a) { return %IsStrong(a) }\nf(undefined)",
1 * kPointerSize,
2,
10,
{
- B(Ldar), A(1, 2), //
- B(Star), R(0), //
- B(CallRuntime), U16(Runtime::kIsArray), R(0), U8(1), //
- B(Return) //
+ B(Ldar), A(1, 2), //
+ B(Star), R(0), //
+ B(CallRuntime), U16(Runtime::kIsStrong), R(0), U8(1), //
+ B(Return) //
},
},
{
@@ -5763,39 +5763,39 @@ TEST(ForOf) {
1,
82,
{
- B(CreateArrayLiteral), U8(0), U8(0), U8(array_literal_flags), //
- B(Star), R(5), //
- B(LdaConstant), U8(1), //
- B(KeyedLoadICSloppy), R(5), U8(vector->GetIndex(slot2)), //
- B(Star), R(4), //
- B(Call), R(4), R(5), U8(0), U8(vector->GetIndex(slot1)), //
- B(Star), R(1), //
- B(Ldar), R(1), //
- B(Star), R(6), //
- B(LoadICSloppy), R(6), U8(2), U8(vector->GetIndex(slot4)), //
- B(Star), R(5), //
- B(Call), R(5), R(6), U8(0), U8(vector->GetIndex(slot3)), //
- B(Star), R(2), //
- B(Star), R(4), //
- B(CallRuntime), U16(Runtime::kInlineIsJSReceiver), R(4), U8(1), //
- B(LogicalNot), //
- B(JumpIfFalse), U8(11), //
- B(Ldar), R(2), //
- B(Star), R(4), //
- B(CallRuntime), U16(Runtime::kThrowIteratorResultNotAnObject), //
- R(4), U8(1), //
- B(Ldar), R(2), //
- B(Star), R(4), //
- B(LoadICSloppy), R(4), U8(3), U8(vector->GetIndex(slot5)), //
- B(JumpIfToBooleanTrue), U8(16), //
- B(Ldar), R(2), //
- B(Star), R(4), //
- B(LoadICSloppy), R(4), U8(4), U8(vector->GetIndex(slot6)), //
- B(Star), R(0), //
- B(Star), R(3), //
- B(Jump), U8(-58), //
- B(LdaUndefined), //
- B(Return), //
+ B(CreateArrayLiteral), U8(0), U8(0), U8(array_literal_flags), //
+ B(Star), R(5), //
+ B(LdaConstant), U8(1), //
+ B(KeyedLoadICSloppy), R(5), U8(vector->GetIndex(slot2)), //
+ B(Star), R(4), //
+ B(Call), R(4), R(5), U8(0), U8(vector->GetIndex(slot1)), //
+ B(Star), R(1), //
+ B(Ldar), R(1), //
+ B(Star), R(6), //
+ B(LoadICSloppy), R(6), U8(2), U8(vector->GetIndex(slot4)), //
+ B(Star), R(5), //
+ B(Call), R(5), R(6), U8(0), U8(vector->GetIndex(slot3)), //
+ B(Star), R(2), //
+ B(Star), R(4), //
+ B(IntrinsicOneArg), U16(Runtime::kInlineIsJSReceiver), R16(4), //
+ B(LogicalNot), //
+ B(JumpIfFalse), U8(11), //
+ B(Ldar), R(2), //
+ B(Star), R(4), //
+ B(CallRuntime), U16(Runtime::kThrowIteratorResultNotAnObject), //
+ R(4), U8(1), //
+ B(Ldar), R(2), //
+ B(Star), R(4), //
+ B(LoadICSloppy), R(4), U8(3), U8(vector->GetIndex(slot5)), //
+ B(JumpIfToBooleanTrue), U8(16), //
+ B(Ldar), R(2), //
+ B(Star), R(4), //
+ B(LoadICSloppy), R(4), U8(4), U8(vector->GetIndex(slot6)), //
+ B(Star), R(0), //
+ B(Star), R(3), //
+ B(Jump), U8(-58), //
+ B(LdaUndefined), //
+ B(Return), //
},
5,
{InstanceType::FIXED_ARRAY_TYPE, InstanceType::SYMBOL_TYPE,
@@ -5808,40 +5808,40 @@ TEST(ForOf) {
1,
81,
{
- B(LdaConstant), U8(0), //
- B(Star), R(3), //
- B(Star), R(6), //
- B(LdaConstant), U8(1), //
- B(KeyedLoadICSloppy), R(6), U8(vector->GetIndex(slot2)), //
- B(Star), R(5), //
- B(Call), R(5), R(6), U8(0), U8(vector->GetIndex(slot1)), //
- B(Star), R(1), //
- B(Ldar), R(1), //
- B(Star), R(7), //
- B(LoadICSloppy), R(7), U8(2), U8(vector->GetIndex(slot4)), //
- B(Star), R(6), //
- B(Call), R(6), R(7), U8(0), U8(vector->GetIndex(slot3)), //
- B(Star), R(2), //
- B(Star), R(5), //
- B(CallRuntime), U16(Runtime::kInlineIsJSReceiver), R(5), U8(1), //
- B(LogicalNot), //
- B(JumpIfFalse), U8(11), //
- B(Ldar), R(2), //
- B(Star), R(5), //
- B(CallRuntime), U16(Runtime::kThrowIteratorResultNotAnObject), //
- R(5), U8(1), //
- B(Ldar), R(2), //
- B(Star), R(5), //
- B(LoadICSloppy), R(5), U8(3), U8(vector->GetIndex(slot5)), //
- B(JumpIfToBooleanTrue), U8(15), //
- B(Ldar), R(2), //
- B(Star), R(5), //
- B(LoadICSloppy), R(5), U8(4), U8(vector->GetIndex(slot6)), //
- B(Star), R(0), //
- B(Star), R(4), //
- B(Return), //
- B(LdaUndefined), //
- B(Return), //
+ B(LdaConstant), U8(0), //
+ B(Star), R(3), //
+ B(Star), R(6), //
+ B(LdaConstant), U8(1), //
+ B(KeyedLoadICSloppy), R(6), U8(vector->GetIndex(slot2)), //
+ B(Star), R(5), //
+ B(Call), R(5), R(6), U8(0), U8(vector->GetIndex(slot1)), //
+ B(Star), R(1), //
+ B(Ldar), R(1), //
+ B(Star), R(7), //
+ B(LoadICSloppy), R(7), U8(2), U8(vector->GetIndex(slot4)), //
+ B(Star), R(6), //
+ B(Call), R(6), R(7), U8(0), U8(vector->GetIndex(slot3)), //
+ B(Star), R(2), //
+ B(Star), R(5), //
+ B(IntrinsicOneArg), U16(Runtime::kInlineIsJSReceiver), R16(5), //
+ B(LogicalNot), //
+ B(JumpIfFalse), U8(11), //
+ B(Ldar), R(2), //
+ B(Star), R(5), //
+ B(CallRuntime), U16(Runtime::kThrowIteratorResultNotAnObject), //
+ R(5), U8(1), //
+ B(Ldar), R(2), //
+ B(Star), R(5), //
+ B(LoadICSloppy), R(5), U8(3), U8(vector->GetIndex(slot5)), //
+ B(JumpIfToBooleanTrue), U8(15), //
+ B(Ldar), R(2), //
+ B(Star), R(5), //
+ B(LoadICSloppy), R(5), U8(4), U8(vector->GetIndex(slot6)), //
+ B(Star), R(0), //
+ B(Star), R(4), //
+ B(Return), //
+ B(LdaUndefined), //
+ B(Return), //
},
5,
{InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
@@ -5857,50 +5857,50 @@ TEST(ForOf) {
1,
104,
{
- B(CreateArrayLiteral), U8(0), U8(0), U8(array_literal_flags), //
- B(Star), R(5), //
- B(LdaConstant), U8(1), //
- B(KeyedLoadICSloppy), R(5), U8(vector->GetIndex(slot2)), //
- B(Star), R(4), //
- B(Call), R(4), R(5), U8(0), U8(vector->GetIndex(slot1)), //
- B(Star), R(1), //
- B(Ldar), R(1), //
- B(Star), R(6), //
- B(LoadICSloppy), R(6), U8(2), U8(vector->GetIndex(slot4)), //
- B(Star), R(5), //
- B(Call), R(5), R(6), U8(0), U8(vector->GetIndex(slot3)), //
- B(Star), R(2), //
- B(Star), R(4), //
- B(CallRuntime), U16(Runtime::kInlineIsJSReceiver), R(4), U8(1), //
- B(LogicalNot), //
- B(JumpIfFalse), U8(11), //
- B(Ldar), R(2), //
- B(Star), R(4), //
- B(CallRuntime), U16(Runtime::kThrowIteratorResultNotAnObject), //
- R(4), U8(1), //
- B(Ldar), R(2), //
- B(Star), R(4), //
- B(LoadICSloppy), R(4), U8(3), U8(vector->GetIndex(slot5)), //
- B(JumpIfToBooleanTrue), U8(38), //
- B(Ldar), R(2), //
- B(Star), R(4), //
- B(LoadICSloppy), R(4), U8(4), U8(vector->GetIndex(slot6)), //
- B(Star), R(0), //
- B(Star), R(3), //
- B(Star), R(4), //
- B(LdaSmi8), U8(10), //
- B(TestEqual), R(4), //
- B(JumpIfFalse), U8(4), //
- B(Jump), U8(-66), //
- B(Ldar), R(3), //
- B(Star), R(4), //
- B(LdaSmi8), U8(20), //
- B(TestEqual), R(4), //
- B(JumpIfFalse), U8(4), //
- B(Jump), U8(4), //
- B(Jump), U8(-80), //
- B(LdaUndefined), //
- B(Return), //
+ B(CreateArrayLiteral), U8(0), U8(0), U8(array_literal_flags), //
+ B(Star), R(5), //
+ B(LdaConstant), U8(1), //
+ B(KeyedLoadICSloppy), R(5), U8(vector->GetIndex(slot2)), //
+ B(Star), R(4), //
+ B(Call), R(4), R(5), U8(0), U8(vector->GetIndex(slot1)), //
+ B(Star), R(1), //
+ B(Ldar), R(1), //
+ B(Star), R(6), //
+ B(LoadICSloppy), R(6), U8(2), U8(vector->GetIndex(slot4)), //
+ B(Star), R(5), //
+ B(Call), R(5), R(6), U8(0), U8(vector->GetIndex(slot3)), //
+ B(Star), R(2), //
+ B(Star), R(4), //
+ B(IntrinsicOneArg), U16(Runtime::kInlineIsJSReceiver), R16(4), //
+ B(LogicalNot), //
+ B(JumpIfFalse), U8(11), //
+ B(Ldar), R(2), //
+ B(Star), R(4), //
+ B(CallRuntime), U16(Runtime::kThrowIteratorResultNotAnObject), //
+ R(4), U8(1), //
+ B(Ldar), R(2), //
+ B(Star), R(4), //
+ B(LoadICSloppy), R(4), U8(3), U8(vector->GetIndex(slot5)), //
+ B(JumpIfToBooleanTrue), U8(38), //
+ B(Ldar), R(2), //
+ B(Star), R(4), //
+ B(LoadICSloppy), R(4), U8(4), U8(vector->GetIndex(slot6)), //
+ B(Star), R(0), //
+ B(Star), R(3), //
+ B(Star), R(4), //
+ B(LdaSmi8), U8(10), //
+ B(TestEqual), R(4), //
+ B(JumpIfFalse), U8(4), //
+ B(Jump), U8(-66), //
+ B(Ldar), R(3), //
+ B(Star), R(4), //
+ B(LdaSmi8), U8(20), //
+ B(TestEqual), R(4), //
+ B(JumpIfFalse), U8(4), //
+ B(Jump), U8(4), //
+ B(Jump), U8(-80), //
+ B(LdaUndefined), //
+ B(Return), //
},
5,
{InstanceType::FIXED_ARRAY_TYPE, InstanceType::SYMBOL_TYPE,
@@ -5930,13 +5930,13 @@ TEST(ForOf) {
B(Call), R(4), R(5), U8(0), U8(vector->GetIndex(slot3)), //
B(Star), R(1), //
B(Star), R(3), //
- B(CallRuntime), U16(Runtime::kInlineIsJSReceiver), R(3), U8(1), //
+ B(IntrinsicOneArg), U16(Runtime::kInlineIsJSReceiver), R16(3), //
B(LogicalNot), //
B(JumpIfFalse), U8(11), //
B(Ldar), R(1), //
B(Star), R(3), //
B(CallRuntime), U16(Runtime::kThrowIteratorResultNotAnObject), //
- R(3), U8(1), //
+ R(3), U8(1), //
B(Ldar), R(1), //
B(Star), R(3), //
B(LoadICSloppy), R(3), U8(4), U8(vector->GetIndex(slot5)), //
@@ -5955,8 +5955,7 @@ TEST(ForOf) {
B(Return), //
},
7,
- {InstanceType::FIXED_ARRAY_TYPE,
- InstanceType::FIXED_ARRAY_TYPE,
+ {InstanceType::FIXED_ARRAY_TYPE, InstanceType::FIXED_ARRAY_TYPE,
InstanceType::SYMBOL_TYPE,
InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,

Powered by Google App Engine
This is Rietveld 408576698