Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1645753004: Reland of Update V8 to version 4.10.99. (Closed)

Created:
4 years, 10 months ago by joedow
Modified:
4 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Update V8 to version 4.10.99. (patchset #1 id:1 of https://codereview.chromium.org/1645123002/ ) Reason for revert: Un-reverting this change as a different CL was identified as the culprit. Original issue's description: > Revert of Update V8 to version 4.10.99. (patchset #1 id:1 of https://codereview.chromium.org/1648633002/ ) > > Reason for revert: > Possibly causing compile failure on main chrome waterfall. Reverting... > > Original issue's description: > > Update V8 to version 4.10.99. > > > > Summary of changes available at: > > https://chromium.googlesource.com/v8/v8/+log/e77121fb..86e3d587 > > > > Please follow these instructions for assigning/CC'ing issues: > > https://github.com/v8/v8/wiki/Triaging%20issues > > > > Please close rolling in case of a roll revert: > > https://v8-roll.appspot.com/ > > This only works with a Google account. > > > > TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org > > > > Committed: https://crrev.com/cf82bf409d647e793c5c60aeb3dbf9f4aa13ced7 > > Cr-Commit-Position: refs/heads/master@{#372105} > > TBR=hablich@chromium.org,machenbach@chromium.org,vogelheim@chromium.org,yangguo@chromium.org,v8-autoroll@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/2d45416329fe945aeec8971f585d27f2c0f5b2c8 > Cr-Commit-Position: refs/heads/master@{#372120} TBR=hablich@chromium.org,machenbach@chromium.org,vogelheim@chromium.org,yangguo@chromium.org,v8-autoroll@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/98f6b20893e0ab97fb4215d3defaf4e3178af735 Cr-Commit-Position: refs/heads/master@{#372123}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
joedow
Created Reland of Update V8 to version 4.10.99.
4 years, 10 months ago (2016-01-28 18:59:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1645753004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1645753004/1
4 years, 10 months ago (2016-01-28 19:00:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1645753004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1645753004/1
4 years, 10 months ago (2016-01-28 19:03:50 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-28 19:07:12 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/98f6b20893e0ab97fb4215d3defaf4e3178af735 Cr-Commit-Position: refs/heads/master@{#372123}
4 years, 10 months ago (2016-01-28 19:08:13 UTC) #6
Michael Achenbach
4 years, 10 months ago (2016-01-28 19:08:17 UTC) #7
Message was sent while issue was closed.
lgtm thanks!

Powered by Google App Engine
This is Rietveld 408576698