Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1645713002: Revert of Introduce SelectionAdjuster to adjust selections between DOM tree version and composed tree version (Closed)

Created:
4 years, 11 months ago by lushnikov
Modified:
4 years, 11 months ago
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Introduce SelectionAdjuster to adjust selections between DOM tree version and composed tree version (patchset #2 id:20001 of https://codereview.chromium.org/1630903005/ ) Reason for revert: This patch breaks text selection in DevTools console. Please see http://crbug.com/581800 for details. Original issue's description: > Introduce SelectionAdjuster to adjust selections between DOM tree version and composed tree version > > This patch introduces |SelectionAdjuster| class to consolidate functions > adjusting DOM tree version and composed tree version of selections in > |VisibleSelection| class and |SelectionEditor| in one place to avoid having > six parameters constructor, and rude name function |createWithoutValidation()| > to simplify source code for improving readability. > > Note: For ease of reviewing to compare changes, this patch doesn't leave > functions in original place. Following patch moves them to > "SelectionAdjust.{cpp,h}". > > This patch is a preparation of introducing |m_hasTrailingWhitespace| into > |VisibleSelection| class, which makes six parameters constructor to seven > parameters constructor without this patch. > > BUG=n/a > TEST=n/a; no behavior changes > > Committed: https://crrev.com/647b2143c21fade656c085f5a83426e96acbd38a > Cr-Commit-Position: refs/heads/master@{#371697} TBR=yoichio@chromium.org,hajimehoshi@chromium.org,tkent@chromium.org,xiaochengh@chromium.org,yosin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=n/a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -111 lines) Patch
M third_party/WebKit/Source/core/editing/SelectionEditor.cpp View 2 chunks +35 lines, -55 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelection.h View 4 chunks +3 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelection.cpp View 4 chunks +62 lines, -44 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
lushnikov
4 years, 11 months ago (2016-01-27 20:31:05 UTC) #1
Created Revert of Introduce SelectionAdjuster to adjust selections between DOM
tree version and composed tree version

Powered by Google App Engine
This is Rietveld 408576698