When the user selects "Share" for an offline page, share the online URL.

When the user selects "Share" for an offline page, share the online URL.

Adds a UMA user-action metric for when an offline page is shared.

BUG=568281
Committed: https://crrev.com/e35df65bc0be79b0cf566307432b112b5d592be4
Cr-Commit-Position: refs/heads/master@{#372857}

[dewittj, 2016-01-27 19:17:32]

Description was changed from

==========
When the user selects "Share" for an offline page, share the online URL.

Adds a UMA user-action metric for when an offline page is shared.

BUG=568281
==========

to

==========
When the user selects "Share" for an offline page, share the online URL.

Adds a UMA user-action metric for when an offline page is shared.

BUG=568281
==========

[dewittj, 2016-01-27 19:17:32]

dewittj@chromium.org changed reviewers:
+ fgorski@chromium.org

[fgorski, 2016-01-27 21:41:18]

lgtm with a comment.

https://codereview.chromium.org/1645693002/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
(right):

https://codereview.chromium.org/1645693002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java:890:
RecordUserAction.record("MobileMenuShareOfflinePage");
I'd consider boolean UMA if you care about relative sharing of online vs.
offline content.

[dewittj, 2016-01-27 21:49:03]

dewittj@chromium.org changed reviewers:
+ holte@chromium.org, newt@chromium.org

[dewittj, 2016-01-27 21:50:17]

PTAL reviewers, thanks.

holte: tools/metrics
newt: chrome/android/java

holte: Can you weigh in on whether to have some boolean stat or whether to use a
user action for this?

[newt (away), 2016-01-28 18:11:56]

lgtm

[dewittj, 2016-01-29 17:26:48]

dewittj@chromium.org changed reviewers:
+ isherman@chromium.org

[dewittj, 2016-01-29 17:29:20]

dewittj@chromium.org changed reviewers:
- holte@chromium.org

[dewittj, 2016-01-29 17:29:21]

isherman, ptal.  Any comments on user action vs a boolean histogram?

[fgorski, 2016-01-29 17:32:55]

https://codereview.chromium.org/1645693002/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
(right):

https://codereview.chromium.org/1645693002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java:890:
RecordUserAction.record("MobileMenuShareOfflinePage");
On 2016/01/27 21:41:18, fgorski wrote:
> I'd consider boolean UMA if you care about relative sharing of online vs.
> offline content.

How about recording a user action for sharing a page. And then: having a
histogram for offline vs. not?

That way you get the benefit of the record user action (with the sequencing as
shown in the all hands), and can also figure out what percentage was actually
offline.

[dewittj, 2016-01-29 18:35:52]

https://codereview.chromium.org/1645693002/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
(right):

https://codereview.chromium.org/1645693002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java:890:
RecordUserAction.record("MobileMenuShareOfflinePage");
On 2016/01/29 17:32:54, fgorski wrote:
> On 2016/01/27 21:41:18, fgorski wrote:
> > I'd consider boolean UMA if you care about relative sharing of online vs.
> > offline content.
> 
> How about recording a user action for sharing a page. And then: having a
> histogram for offline vs. not?
> 
> That way you get the benefit of the record user action (with the sequencing as
> shown in the all hands), and can also figure out what percentage was actually
> offline.

Done.

[dewittj, 2016-02-01 17:48:12]

isherman: ping

[Ilya Sherman, 2016-02-01 18:22:17]

Histograms lgtm.  In general histograms are best if you're interested in
comparing frequency of online vs. offline page sharing, and user actions are
nice if you want to explore time-sequenced data.

https://codereview.chromium.org/1645693002/diff/60001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1645693002/diff/60001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:31382: +<histogram
name="OfflinePages.SharedPageWasOffline" enum="Boolean">
nit: Please use a custom enum, with labels like "Offline page" and "Online
page".

[dewittj, 2016-02-02 00:32:38]

The CQ bit was checked by dewittj@chromium.org

[dewittj, 2016-02-02 00:32:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
fgorski@chromium.org, newt@chromium.org, isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/1645693002/#ps80001
(title: "Add custom enum")

[commit-bot: I haz the power, 2016-02-02 00:38:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1645693002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1645693002/80001

[commit-bot: I haz the power, 2016-02-02 02:02:30]

Description was changed from

==========
When the user selects "Share" for an offline page, share the online URL.

Adds a UMA user-action metric for when an offline page is shared.

BUG=568281
==========

to

==========
When the user selects "Share" for an offline page, share the online URL.

Adds a UMA user-action metric for when an offline page is shared.

BUG=568281
==========

[commit-bot: I haz the power, 2016-02-02 02:02:31]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-02-02 02:03:49]

Description was changed from

==========
When the user selects "Share" for an offline page, share the online URL.

Adds a UMA user-action metric for when an offline page is shared.

BUG=568281
==========

to

==========
When the user selects "Share" for an offline page, share the online URL.

Adds a UMA user-action metric for when an offline page is shared.

BUG=568281

Committed: https://crrev.com/e35df65bc0be79b0cf566307432b112b5d592be4
Cr-Commit-Position: refs/heads/master@{#372857}
==========

[commit-bot: I haz the power, 2016-02-02 02:03:51]

Patchset 5 (id:??) landed as
https://crrev.com/e35df65bc0be79b0cf566307432b112b5d592be4
Cr-Commit-Position: refs/heads/master@{#372857}