Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: src/IceAssemblerARM32.cpp

Issue 1645683003: Add vmov between floating point registers to ARM assembler. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Fix nits. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceAssemblerARM32.cpp
diff --git a/src/IceAssemblerARM32.cpp b/src/IceAssemblerARM32.cpp
index c9282fe71d3399d1ffb87c5424be986dfe38a7e6..29a9c25f12806ffdcb489555b85a48796ceb0068 100644
--- a/src/IceAssemblerARM32.cpp
+++ b/src/IceAssemblerARM32.cpp
@@ -2413,6 +2413,20 @@ void AssemblerARM32::vmovd(const Operand *OpDd,
emitVFPddd(Cond, OpcodePlusImm8, Dd, D0, D0);
}
+void AssemblerARM32::vmovdd(const Operand *OpDd, const Operand *OpDm,
+ CondARM32::Cond Cond) {
+ // VMOV (register) - ARM section A8.8.340, encoding A2:
+ // vmov<c>.f64 <Dd>, <Sm>
+ //
+ // cccc11101D110000dddd101101M0mmmm where cccc=Cond, Ddddd=Sd, and Mmmmm=Sm.
+ constexpr const char *Vmovdd = "Vmovdd";
+ IValueT Dd = encodeSRegister(OpDd, "Dd", Vmovdd);
+ IValueT Dm = encodeSRegister(OpDm, "Dm", Vmovdd);
+ constexpr IValueT VmovddOpcode = B23 | B21 | B20 | B6;
+ constexpr IValueT D0 = 0;
+ emitVFPddd(Cond, VmovddOpcode, Dd, D0, Dm);
+}
+
void AssemblerARM32::vmovs(const Operand *OpSd,
const OperandARM32FlexFpImm *OpFpImm,
CondARM32::Cond Cond) {
@@ -2430,6 +2444,20 @@ void AssemblerARM32::vmovs(const Operand *OpSd,
emitVFPsss(Cond, OpcodePlusImm8, Sd, S0, S0);
}
+void AssemblerARM32::vmovss(const Operand *OpSd, const Operand *OpSm,
+ CondARM32::Cond Cond) {
+ // VMOV (register) - ARM section A8.8.340, encoding A2:
+ // vmov<c>.f32 <Sd>, <Sm>
+ //
+ // cccc11101D110000dddd101001M0mmmm where cccc=Cond, ddddD=Sd, and mmmmM=Sm.
+ constexpr const char *Vmovss = "Vmovss";
+ IValueT Sd = encodeSRegister(OpSd, "Sd", Vmovss);
+ IValueT Sm = encodeSRegister(OpSm, "Sm", Vmovss);
+ constexpr IValueT VmovssOpcode = B23 | B21 | B20 | B6;
+ constexpr IValueT S0 = 0;
+ emitVFPsss(Cond, VmovssOpcode, Sd, S0, Sm);
+}
+
void AssemblerARM32::vmovsr(const Operand *OpSn, const Operand *OpRt,
CondARM32::Cond Cond) {
// VMOV (between ARM core register and single-precision register)

Powered by Google App Engine
This is Rietveld 408576698