Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1645653003:
Creating a CBCentralManager mock for all tests. (Closed)
DescriptionCreating a CBCentralManager mock for all tests.
BUG=
Committed: https://crrev.com/51302060240ac9c522fc40d663f1b87b25f3705e
Cr-Commit-Position: refs/heads/master@{#371852}
Patch Set 1 #
Messages
Total messages: 21 (9 generated)
The CQ bit was checked by jlebel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1645653003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1645653003/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Hello Vincent, Can you review my CL? Jérôme,
The CQ bit was checked by jlebel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1645653003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1645653003/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
jlebel@chromium.org changed reviewers: + scheib@chromium.org
Hello Vincent, Can you review my patch? Thanks, Jérôme,
The CQ bit was checked by scheib@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1645653003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1645653003/1
LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by scheib@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1645653003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1645653003/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Creating a CBCentralManager mock for all tests. BUG= ========== to ========== Creating a CBCentralManager mock for all tests. BUG= Committed: https://crrev.com/51302060240ac9c522fc40d663f1b87b25f3705e Cr-Commit-Position: refs/heads/master@{#371852} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/51302060240ac9c522fc40d663f1b87b25f3705e Cr-Commit-Position: refs/heads/master@{#371852} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
