Hide SkPixelXorXfermode from Chrome

Hide SkPixelXorXfermode from Chrome

The goal here is to have Android & Skia know about SkPixelXorXfermode but not Chrome.

See also https://codereview.chromium.org/1644703002/ ( Disable deprecated Skia xfermodes) which handles the Chrome side.

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1645633003

[robertphillips, 2016-01-27 19:20:45]

Description was changed from

==========
Hide SkPixelXorXfermode from Chrome
==========

to

==========
Hide SkPixelXorXfermode from Chrome
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-01-27 19:38:53]

Description was changed from

==========
Hide SkPixelXorXfermode from Chrome
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Hide SkPixelXorXfermode from Chrome

The goal here is to have Android & Skia know about SkPixelXorXfermode but not
Chrome.

See also https://codereview.chromium.org/1644703002/ ( Disable deprecated Skia
xfermodes) which handles the Chrome side.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-01-27 19:38:53]

robertphillips@google.com changed reviewers:
+ fmalita@chromium.org, reed@google.com

[f(malita), 2016-01-27 20:02:04]

https://codereview.chromium.org/1645633003/diff/1/gm/pixelxorxfermode.cpp
File gm/pixelxorxfermode.cpp (right):

https://codereview.chromium.org/1645633003/diff/1/gm/pixelxorxfermode.cpp#new...
gm/pixelxorxfermode.cpp:15: #if SK_INCLUDE_DEPRECATED_XFERMODES
Nit: would it make more sense to use SK_SUPPORT_LEGACY_FOO style defines for
deprecation?  That way clients which don't need the feature (Chrome) don't have
to do anything about it.

[f(malita), 2016-01-27 20:44:45]

https://codereview.chromium.org/1645633003/diff/1/gm/pixelxorxfermode.cpp
File gm/pixelxorxfermode.cpp (right):

https://codereview.chromium.org/1645633003/diff/1/gm/pixelxorxfermode.cpp#new...
gm/pixelxorxfermode.cpp:15: #if SK_INCLUDE_DEPRECATED_XFERMODES
On 2016/01/27 20:02:04, f(malita) wrote:
> Nit: would it make more sense to use SK_SUPPORT_LEGACY_FOO style defines for
> deprecation?  That way clients which don't need the feature (Chrome) don't
have
> to do anything about it.

Per conversation, LGTM.

[mtklein, 2016-01-27 20:49:21]

mtklein@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2016-01-27 20:49:21]

any changes to SkValue lgtm

(about to delete it)

[robertphillips, 2016-01-27 21:35:32]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-27 21:35:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1645633003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1645633003/1

[commit-bot: I haz the power, 2016-01-27 21:36:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-27 21:36:16]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[robertphillips, 2016-01-27 21:55:57]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-27 21:56:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1645633003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1645633003/20001

[commit-bot: I haz the power, 2016-01-27 22:08:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-27 22:08:11]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-01-28 20:24:03]

Abandoning in favor of https://codereview.chromium.org/1645093002/ (Move
SkPixelXorXfermode.h to include/client/android)