Issue 1645633002: Rebase on latest package:collection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1645633002: Rebase on latest package:collection (Closed)

Created:
4 years, 11 months ago by vsm

Modified:
4 years, 11 months ago

Reviewers:
Jennifer Messerly

CC:
dev-compiler+reviews_dartlang.org

Base URL:
https://github.com/dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+54 lines, -13 lines)			Patch
M	test/codegen/expect/collection/algorithms.js	View	4 chunks	+42 lines, -5 lines	0 comments	Download
M	test/codegen/expect/collection/algorithms.txt	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	test/codegen/expect/collection/src/canonicalized_map.js	View	1 chunk	+6 lines, -3 lines	0 comments	Download
M	test/codegen/expect/collection/src/canonicalized_map.txt	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/codegen/expect/collection/src/unmodifiable_wrappers.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/codegen/expect/collection/wrappers.txt	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (1 generated)

vsm

Committed patchset #1 (id:1) manually as 2b44887d6cade2016e3c9366fce03631c54d1831 (presubmit successful).

4 years, 11 months ago (2016-01-27 16:49:49 UTC) #2

Jennifer Messerly

4 years, 11 months ago (2016-01-27 17:31:51 UTC) #3

Message was sent while issue was closed.

LGTM. "pub upgrade" pulls a new one? We could remove this from checked in
expectations, if it would help?