content/browser/renderer_host/render_widget_host_view_android.cc - Issue 1645613007: Redefined the bit WebTouchEvent.causesScrollingIfUncanceled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 1645613007: Redefined the bit WebTouchEvent.causesScrollingIfUncanceled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed an aura unittest. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/input/touch_event_queue_unittest.cc ('k') | content/common/input/synthetic_web_input_event_builders.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_android.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc

index 8b52e6b82c8d723bb996be39900b6bc717f75384..ae5820ffd305d5fefaf778fa740e2c1a4f2281a3 100644

--- a/content/browser/renderer_host/render_widget_host_view_android.cc

+++ b/content/browser/renderer_host/render_widget_host_view_android.cc

@@ -738,15 +738,15 @@ bool RenderWidgetHostViewAndroid::OnTouchEvent(

if (!result.succeeded)

return false;

- blink::WebTouchEvent web_event =

- ui::CreateWebTouchEventFromMotionEvent(event, result.did_generate_scroll);

+ blink::WebTouchEvent web_event = ui::CreateWebTouchEventFromMotionEvent(

+ event, result.moved_beyond_slop_region);

host_->ForwardTouchEventWithLatencyInfo(web_event, ui::LatencyInfo());

// Send a proactive BeginFrame for this vsync to reduce scroll latency for

// scroll-inducing touch events. Note that Android's Choreographer ensures

// that BeginFrame requests made during ACTION_MOVE dispatch will be honored

// in the same vsync phase.

- if (observing_root_window_ && result.did_generate_scroll)

+ if (observing_root_window_ && result.moved_beyond_slop_region)

RequestVSyncUpdate(BEGIN_FRAME);

return true;