Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Unified Diff: ui/events/gesture_detection/filtered_gesture_provider.h

Issue 1645613007: Redefined the bit WebTouchEvent.causesScrollingIfUncanceled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/events/gesture_detection/filtered_gesture_provider.h
diff --git a/ui/events/gesture_detection/filtered_gesture_provider.h b/ui/events/gesture_detection/filtered_gesture_provider.h
index d8a8dc0d252bac767ce062f6c5a1d3437e8996a0..c39ae8d42302032999dedadfa18687b7e93cd7fd 100644
--- a/ui/events/gesture_detection/filtered_gesture_provider.h
+++ b/ui/events/gesture_detection/filtered_gesture_provider.h
@@ -34,11 +34,8 @@ class GESTURE_DETECTION_EXPORT FilteredGestureProvider
// |event| and cease further propagation.
bool succeeded;
- // Whether |event| produced scrolling motion, either the start of a scroll,
- // subsequent scroll movement or a fling event.
- // TODO(jdduke): Figure out a way to guarantee that this bit propagates with
- // the processed touch event as it moves downstream.
- bool did_generate_scroll;
+ // Whether |event| occurred beyond the touch slop region.
+ bool moved_beyond_slop_region;
};
TouchHandlingResult OnTouchEvent(const MotionEvent& event) WARN_UNUSED_RESULT;
@@ -66,7 +63,7 @@ class GESTURE_DETECTION_EXPORT FilteredGestureProvider
ui::TouchDispositionGestureFilter gesture_filter_;
bool handling_event_;
- bool last_touch_event_did_generate_scroll_;
+ bool last_touch_event_moved_beyond_slop_region_;
ui::GestureEventDataPacket pending_gesture_packet_;
DISALLOW_COPY_AND_ASSIGN(FilteredGestureProvider);

Powered by Google App Engine
This is Rietveld 408576698