content/common/input/synthetic_web_input_event_builders.cc - Issue 1645613007: Redefined the bit WebTouchEvent.causesScrollingIfUncanceled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/input/synthetic_web_input_event_builders.cc

Issue 1645613007: Redefined the bit WebTouchEvent.causesScrollingIfUncanceled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_android.cc ('k') | content/common/input/web_input_event_traits.cc » ('j') | third_party/WebKit/public/web/WebInputEvent.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/input/synthetic_web_input_event_builders.cc

diff --git a/content/common/input/synthetic_web_input_event_builders.cc b/content/common/input/synthetic_web_input_event_builders.cc

index e2e17febb95b059c90d1b72a89cdcf5753ac010f..4ba93d317694707f1fa2428ab3a079b60e8dcd6e 100644

--- a/content/common/input/synthetic_web_input_event_builders.cc

+++ b/content/common/input/synthetic_web_input_event_builders.cc

@@ -171,7 +171,7 @@ void SyntheticWebTouchEvent::ResetPoints() {

}

touchesLength = point;

type = WebInputEvent::Undefined;

- causesScrollingIfUncanceled = false;

+ movedBeyondSlopRegion = false;

uniqueTouchEventId = ui::GetNextTouchEventId();

}

@@ -198,7 +198,7 @@ void SyntheticWebTouchEvent::MovePoint(int index, float x, float y) {

CHECK_LT(index, touchesLengthCap);

// Always set this bit to avoid otherwise unexpected touchmove suppression.

// The caller can opt-out explicitly, if necessary.

- causesScrollingIfUncanceled = true;

+ movedBeyondSlopRegion = true;

WebTouchPoint& point = touches[index];

point.position.x = point.screenPosition.x = x;

point.position.y = point.screenPosition.y = y;