Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 1645613006: fix teeny dashed path bug (Closed)

Created:
4 years, 10 months ago by caryclark
Modified:
4 years, 10 months ago
Reviewers:
f(malita), reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fix teeny dashed path bug If the path dashed is sufficiently small, there may be no segments generated to dash. Check for an empty segment list. R=reed@google.com BUG=skia:4871 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1645613006 Committed: https://skia.googlesource.com/skia/+/703348f5fac69dbedf22cda2ce264d2c9683bcf3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M src/core/SkPathMeasure.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/DashPathEffectTest.cpp View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1645613006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1645613006/1
4 years, 10 months ago (2016-01-29 16:22:03 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-01-29 16:46:59 UTC) #5
caryclark
PTAL
4 years, 10 months ago (2016-01-29 17:50:49 UTC) #6
f(malita)
lgtm
4 years, 10 months ago (2016-01-29 17:51:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1645613006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1645613006/1
4 years, 10 months ago (2016-01-29 17:53:27 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-01-29 17:54:30 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/703348f5fac69dbedf22cda2ce264d2c9683bcf3

Powered by Google App Engine
This is Rietveld 408576698