Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1645613005: Refactor _LibraryResynthesizer.getReferencedLocation. (Closed)

Created:
4 years, 10 months ago by Paul Berry
Modified:
4 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Refactor _LibraryResynthesizer.getReferencedLocation. The new implementation now handles locations both inside and outside the current library. Also it returns the components of the location rather than the location object itself; in a future CL this will allow us to append additional components to the location. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/a456e97d9e27b739219f9af4ba2617242a2db717

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -33 lines) Patch
M pkg/analyzer/lib/src/summary/resynthesize.dart View 5 chunks +28 lines, -33 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 10 months ago (2016-01-29 00:22:41 UTC) #2
scheglov
LGTM
4 years, 10 months ago (2016-01-29 01:00:49 UTC) #3
Paul Berry
4 years, 10 months ago (2016-01-29 13:33:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a456e97d9e27b739219f9af4ba2617242a2db717 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698