Emit notes from ReportClassRequiresTraceMethod in deterministic order

Emit notes from ReportClassRequiresTraceMethod in deterministic order

Previously, the notes would be emitted in the iteration order over Fields,
which is an std::map<clang::FieldDecl*, FieldPoint>, which is ordered
by pointer value of FieldDecls. This would cause tests to flakily fail
on the Windows buildbots.

I'm not sure what caused these errors to start appearing right now,
but this should fix it.

BUG=581782
Committed: https://crrev.com/f544ddc9eed935d855f45045698afd9118134fff
Cr-Commit-Position: refs/heads/master@{#372016}

[hans, 2016-01-28 02:17:06]

hans@chromium.org changed reviewers:
+ sigbjornf@opera.se, thakis@chromium.org

[hans, 2016-01-28 02:17:07]

Please take a look.

[Nico, 2016-01-28 03:29:07]

Lgtm assuming source location has an OP<

[hans, 2016-01-28 04:15:43]

On 2016/01/28 03:29:07, Nico wrote:
> Lgtm assuming source location has an OP<

Yes, it does:
http://clang.llvm.org/doxygen/namespaceclang.html#a257a73888f07ffc86da7e6fd16...

[hans, 2016-01-28 04:15:48]

The CQ bit was checked by hans@chromium.org

[commit-bot: I haz the power, 2016-01-28 04:16:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1645613003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1645613003/1

[commit-bot: I haz the power, 2016-01-28 04:42:44]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-28 04:43:41]

Description was changed from

==========
Emit notes from ReportClassRequiresTraceMethod in deterministic order

Previously, the notes would be emitted in the iteration order over Fields,
which is an std::map<clang::FieldDecl*, FieldPoint>, which is ordered
by pointer value of FieldDecls. This would cause tests to flakily fail
on the Windows buildbots.

I'm not sure what caused these errors to start appearing right now,
but this should fix it.

BUG=581782
==========

to

==========
Emit notes from ReportClassRequiresTraceMethod in deterministic order

Previously, the notes would be emitted in the iteration order over Fields,
which is an std::map<clang::FieldDecl*, FieldPoint>, which is ordered
by pointer value of FieldDecls. This would cause tests to flakily fail
on the Windows buildbots.

I'm not sure what caused these errors to start appearing right now,
but this should fix it.

BUG=581782

Committed: https://crrev.com/f544ddc9eed935d855f45045698afd9118134fff
Cr-Commit-Position: refs/heads/master@{#372016}
==========

[commit-bot: I haz the power, 2016-01-28 04:43:47]

Patchset 1 (id:??) landed as
https://crrev.com/f544ddc9eed935d855f45045698afd9118134fff
Cr-Commit-Position: refs/heads/master@{#372016}

[Nico, 2016-04-04 13:41:28]

sof pointed out on https://codereview.chromium.org/1645763004/ a while ago that
you wanted to revert this. Do you still want to do that? (Or did you already do
that and I just missed it?)

[hans, 2016-04-04 15:59:21]

On 2016/04/04 13:41:28, Nico wrote:
> sof pointed out on https://codereview.chromium.org/1645763004/ a while ago
that
> you wanted to revert this. Do you still want to do that? (Or did you already
do
> that and I just missed it?)

The revert was part of what landed in
https://codereview.chromium.org/1645763004/ (Patch set 3 "revert the old fix
attempt")