Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 1645583002: Display -webkit-filter objects in any column (instead of only in the first one). (Closed)

Created:
4 years, 11 months ago by mstensho (USE GERRIT)
Modified:
4 years, 11 months ago
Reviewers:
Xianzhu
CC:
chromium-reviews, blink-reviews, mstensho (USE GERRIT), dshwang, slimming-paint-reviews_chromium.org, blink-reviews-paint_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Display -webkit-filter objects in any column (instead of only in the first one). Most of our painting-related operations take place after fragmentation, i.e. via PaintLayerPainter::paintFragmentWithPhase(). All such operations can just sit back and relax and not worry about fragmentation, since translation and clipping for a given fragmentainer (column) has already taken place. This is not the case for filters, though. They are set up before fragmentation. Therefore, we need to make the bounding box of the layer visual (convert out of the flow thread coordinate space) on our own. We now do this specifically for filters, or we'd upset other parts of the code, such as clip path. BUG=530074 R=wangxianzhu@chromium.org Committed: https://crrev.com/17e31b8972050ad7791d2243a19f07ba8fc9c54f Cr-Commit-Position: refs/heads/master@{#371808}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -8 lines) Patch
A third_party/WebKit/LayoutTests/fast/multicol/filter-in-second-column.html View 1 chunk +6 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/multicol/filter-in-second-column-expected.html View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FilterPainter.cpp View 1 chunk +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 3 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mstensho (USE GERRIT)
4 years, 11 months ago (2016-01-27 16:04:35 UTC) #1
Xianzhu
lgtm
4 years, 11 months ago (2016-01-27 17:03:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1645583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1645583002/1
4 years, 11 months ago (2016-01-27 17:05:00 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 17:12:14 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 17:13:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/17e31b8972050ad7791d2243a19f07ba8fc9c54f
Cr-Commit-Position: refs/heads/master@{#371808}

Powered by Google App Engine
This is Rietveld 408576698